[3/n] expand cycle detection tests#23
Open
sunshowers wants to merge 3 commits intomainfrom
Open
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
added a commit
that referenced
this pull request
May 8, 2026
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
May 8, 2026
Comment on lines
+4
to
+11
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| - "$ref": "#/components/schemas/AltX" | ||
| + "$ref": "#/components/schemas/AltY" | ||
| } | ||
| } | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
This test covers the A->B->A to B->A->B cycle issue, which it turns out we already handled. (Again, wanted to ensure that #15 didn't regress this.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
tests/cases/cycle-shared-prefixtotests/cases/cycle-detectionto reflect the broader scope, and extend the fixture with a few different kinds of cycles:$refallOfwrappersAlso add tests to verify the outputs. (We're going to rework cycle detection a bit in #15 and want to ensure that PR doesn't introduce any behavior changes.)