Add library for humility dump

Cargo.toml

@@ -13,6 +13,7 @@ members = [
     "humility-core",
     "humility-doppel",
     "humility-dump-agent",
+    "humility-dump",
     "humility-flash",
     "humility-hexdump",
     "humility-hiffy",
@@ -134,6 +135,7 @@ humility-caboose = { path = "./humility-caboose" }
 humility-cli = { path = "./humility-cli", default-features = false }
 humility-doppel = { path = "./humility-doppel" }
 humility-dump-agent = { path = "./humility-dump-agent" }
+humility-dump = { path = "./humility-dump" }
 humility-flash = { path = "./humility-flash" }
 humility-hexdump = { path = "./humility-hexdump" }
 humility-hiffy = { path = "./humility-hiffy" }

cmd/diagnose/Cargo.toml

@@ -13,3 +13,4 @@ humility.workspace = true
 humility-cli.workspace = true
 humility-doppel.workspace = true
 humility-jefe.workspace = true
+humility-dump.workspace = true

cmd/diagnose/src/lib.rs

@@ -327,7 +327,12 @@ fn diagnose(
 
     if !subargs.no_dump {
         section("Generating Coredump");
-        let rval = hubris.dump(core, None, None, None, context.log());
+
+        let (filename, mut file) =
+            humility_dump::open_dump_file(hubris, None, None)?;
+        println!("dumping to {filename:?}");
+
+        let rval = hubris.dump(core, None, &mut file, None, context.log());
 
         if let Err(e) = rval {
             println!("Coredump failed: {}", e);

cmd/dump/Cargo.toml

@@ -21,3 +21,4 @@ humility.workspace = true
 humility-cli.workspace = true
 humility-dump-agent.workspace = true
 humility-arch-arm.workspace = true
+humility-dump.workspace = true