Fix four flaky tests related to inventory collection#10001
Merged
emilyalbini merged 5 commits intomainfrom Mar 10, 2026
Merged
Conversation
emilyalbini
force-pushed
the
ea-two-spurious
branch
2 times, most recently
from
c737cad to
d8058fb
Compare
Member
Author
|
Found more similar spurious failures, will fix them too. |
emilyalbini
force-pushed
the
ea-two-spurious
branch
from
d8058fb to
b9a2056
Compare
emilyalbini
changed the title
emilyalbini
force-pushed
the
ea-two-spurious
branch
from
b9a2056 to
7db4959
Compare
Member
Author
|
Found two more related spurious failures in another job I ran, added the fix for them in this PR too. While I was at it, I audited the calls to Footnotes
|
davepacheco
approved these changes
Mar 10, 2026
Collaborator
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
Thanks! I'd just strike the comment that references an issue that you're fixing here.
Co-authored-by: David Pacheco <dap@oxidecomputer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing larger Helios test runners I encountered two flaky tests.
One was already tracked in #9316, and both seem to be related to inventory collection not being ready yet by the time the test executes. This PR adds retries to both tests to ensure the inventory is available before proceeding.