releng: refactor fetch_hubris_artifacts#10629
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for generating both Tufaceous v1 and v2 repositories. Currently the repo generation task reads all of the measurement files out of
out/releng/hubris-{production,staging}/measurement_corpus. This changesfetch_hubris_artifactsto include them with themanifest.tomlfile, so the repo generation task doesn't need any special logic.This also means we don't need to clear out old artifacts in order for them to be excluded from the repository. Additionally, I changed the downloader to reuse already-cached artifacts if they're available.
Sorry if this diff is hard to follow. I wrote it a month ago and it took me a bit to page all the context back in for why I wrote it like this. I found that reading hubris.rs on its own without the diff helped a lot.