[2/n][fm] factor restart_id and time_created out of EreportData#10631
Open
hawkw wants to merge 1 commit into
Open
[2/n][fm] factor restart_id and time_created out of EreportData#10631hawkw wants to merge 1 commit into
restart_id and time_created out of EreportData#10631hawkw wants to merge 1 commit into
Conversation
hawkw
added
the
fault-management
hawkw
force-pushed
the
eliza/restart-order-ereport-refactor
branch
from
6242a48 to
0b4a9d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #10618
This is a small refactor which I discussed in this comment on #10618. As part of that branch, I changed the
DataStore::ereports_insertmethod to take the restart ID andtime_collectedtimestamp as arguments to the method, since they are used for populating the restart entry. This results in the same values also being passed as part of theEreportDatastructs that represent the individual ereports to insert. This is unfortunate because it results in having to duplicate those values, but more importantly, because it allows them to differ when they should always be the same. This branch fixes that.