Skip to content

[10/n] [sled-agent] make RackNetworkConfig ports a non-empty UplinkPorts newtype#10651

Open
sunshowers wants to merge 2 commits into
sunshowers/spr/main.10n-sled-agent-make-racknetworkconfig-ports-a-non-empty-uplinkports-newtypefrom
sunshowers/spr/10n-sled-agent-make-racknetworkconfig-ports-a-non-empty-uplinkports-newtype
Open

[10/n] [sled-agent] make RackNetworkConfig ports a non-empty UplinkPorts newtype#10651
sunshowers wants to merge 2 commits into
sunshowers/spr/main.10n-sled-agent-make-racknetworkconfig-ports-a-non-empty-uplinkports-newtypefrom
sunshowers/spr/10n-sled-agent-make-racknetworkconfig-ports-a-non-empty-uplinkports-newtype

Conversation

@sunshowers

@sunshowers sunshowers commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

In prior commits in the stack, we made it so that transient DB errors don't result in a partially-generated config. This change encodes one specific form of that (non-empty ports) into the type system.

Making bootstore deserialization fallible is an improvement in this case, because it turns a panic into a loop.

Also include a change to make the rack ID in StartSledAgentRequest a typed RackUuid. This isn't directly related but is spiritually similar and I'm touching this code anyway.

Depends on:

Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant