Conversation
smklein
commented
Mar 5, 2026
jgallagher
reviewed
Mar 5, 2026
This was referenced Mar 5, 2026
Collaborator
Author
|
I think I've addressed all comments here - thanks everyone for the feedback. Anyone willing to give this a look / approval? Or are there any outstanding concerns? |
Collaborator
Author
|
Unless anyone has further objections, I'll plan on landing this about 24 hours from now. Happy to pause for additional feedback, but otherwise I'd like to keep the ball rolling on aligning diesel's schema with Cockroach's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This schema change aligns the database with existing diesel models in Rust
Part of #9966