[nexus] make almost all saga action failures accept an omicron error#9998
Merged
sunshowers merged 2 commits intomainfrom Mar 9, 2026
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #9997 I saw this error in the logs:
The root cause for that was that we were passing in a string as an error rather than a structured omicron-common error. That's because steno's
ActionError::action_failedaccepts anything that implementsDebug + DeserializeOwned.Fix this by:
nexus_types::saga::saga_action_failedActionError::action_failedthrough clippy disallowed-methodsThere are two instances of
ActionError::action_failedthat remain, both of which are marked withexpect(clippy::disallowed_methods):saga_action_failed.nexus/src/app/sagas/instance_update/mod.rs, the instance updater lock error which is handled specially.