add retry_operation_indefinitely and retry_operation_while_indefinitely#3
Merged
sunshowers merged 4 commits intomainfrom Mar 9, 2026
Conversation
Created using spr 1.3.6-beta.1
jmpesp
approved these changes
Mar 9, 2026
| } | ||
| let delay = delays | ||
| .next() | ||
| .expect("infinite backoff iterator produced a delay"); |
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Collaborator
Author
|
Thanks @jmpesp -- going to get this out and update omicron today. |
sunshowers
deleted the
sunshowers/spr/add-retry_operation_indefinitely-and-retry_operation_while_indefinitely
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2.
I've tested this with the new test added in oxidecomputer/omicron#9997. I've also tested a local change which enables the clippy::disallowed_methods lint in omicron for
retry_operationandretry_operation_while, suggesting use of_indefinitelyinstead. I believe that should be a complete structural fix for #2.