Ndh/spd proxy fixes#495
Draft
nathanaelhuffman wants to merge 6 commits intomainfrom
Draft
Conversation
The REDGE-exit branch (cpu_scl_in='1' catch-up) set dimm_sda_oe one registered cycle after the rising edge, while the playback SCL was still high -- producing a spurious start or stop condition on the DIMM bus. The FEDGE path already handles catch-up exit correctly, so just remove the REDGE branch and let playback_bits increment cleanly.
nathanaelhuffman
force-pushed
the
ndh/spd-proxy-fixes
branch
from
510d731 to
637ca79
Compare
| -- License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| -- file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
| -- | ||
| -- Copyright 2025 Oxide Computer Company |
Collaborator
There was a problem hiding this comment.
Suggested change
| -- Copyright 2025 Oxide Computer Company | |
| -- Copyright 2026 Oxide Computer Company |
Do we need this statement even? Over in hubris we don't have it and just use those first 3 MPL lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.