[rejected AI] Fix count=True ignoring non-zero default - #3842
Closed
ShamikOfficial wants to merge 1 commit into
Closed
[rejected AI] Fix count=True ignoring non-zero default#3842ShamikOfficial wants to merge 1 commit into
ShamikOfficial wants to merge 1 commit into
Conversation
Count increments relative to the option default (and default_map) when flags are passed on the command line, matching argparse. Fixes pallets#3841. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@click.command()
@click.option("-v", count=True, default="3")
def cli(v):
click.echo(v)
runner.invoke(cli, []).output # "3\n" (an int in the callback)
runner.invoke(cli, ["-v"]).exception
# TypeError: can only concatenate str (not "int") to strThe same exception occurs with |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
count=Trueoptions have a non-zerodefault, Click previously counted from0whenever the flag appeared on the command line. That could produce a value lower than the default (for exampledefault=3with one-vyielded1).This change makes command-line counts additive relative to the option default (and
Context.default_mapwhen present), matchingargparseaction="count".fixes #3841
default_mapbaseline test.Optiondocstring (.. versionchanged:: 8.5.1).CHANGES.mdentry under 8.5.1.