[rejected AI] Fix BOOL conversion of 0 and 1 - #3849
Closed
Wahib294 wants to merge 1 commit into
Closed
Conversation
Member
BOOL conversion of 0 and 1BOOL conversion of 0 and 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOOLraisesAttributeError: 'int' object has no attribute 'strip'when itreceives a number instead of a string. This happens for a boolean option with
default=1ordefault=0, for adefault_maploaded from a config filewhere a boolean came through as a number, and for
click.prompt(type=bool)with a numeric default.
Click 8.0 through 8.2.1 accepted
0and1through thevalue in {False, True}guard added in e79c2b4. #2956 (8.2.2) replaced it with
isinstance(value, bool)while reworking
str_to_bool, so numbers now fall through to the string path.This restores the guard and passes the value through
str()before thelookup, so
0and1convert toFalseandTrueagain and any othernon-string input produces the usual "is not a valid boolean" error instead of
a traceback.
fixes #3846