Conversation
Member
davidism
added
the
rejected AI
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the internal implementations to
_FuncParamTypeand_convert_type, while keeping the old module attributes available through__getattr__with a deprecation warning until Click 9.0. Internal call sites and tests now use the private names.The existing
to_info_dict()output remains compatible (param_typeis stillFunc).Validation:
uv run pytest(2062 passed, 24 skipped, 1 xfailed)uv run tox run -e style,typingDeveloped with assistance from OpenAI Codex.
Fixes #3847