[rejected AI] Fix Windows click.edit notepad launch failures - #3856
Closed
seethinajayadileep wants to merge 2 commits into
Closed
[rejected AI] Fix Windows click.edit notepad launch failures#3856seethinajayadileep wants to merge 2 commits into
seethinajayadileep wants to merge 2 commits into
Conversation
added 2 commits
September 7, 2026 16:42
Resolve notepad.exe to a full System32 path on Windows and launch via a proper argv list so CreateProcess no longer fails intermittently with WinError 87/14001. Fixes pallets#3840 Signed-off-by: JAYA DILEEP <seethinajayadileep@hotmail.com>
Signed-off-by: JAYA DILEEP <seethinajayadileep@hotmail.com>
Member
davidism
added
the
rejected AI
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
click.edit()intermittently fails when launching the default editor (notepad).CreateProcessraisesWinError 87(parameter is incorrect) orWinError 14001(side-by-side configuration incorrect). The default editor string was the bare name"notepad", and POSIXshlex.splitcan also mangle unquoted Windows paths that contain backslashes.Solution
notepad.exepath viashutil.which, falling back to%SystemRoot%\\System32\\notepad.exe(or%WINDIR%/C:\\Windows).shlex.split(..., posix=False)so backslashes are preserved forCreateProcess.self.envinto a copy ofos.environ(unchanged).get_editor()resolution and argv construction for the System32 notepad path.Fixes #3840