type *core/base.pyi, remove SelectionMixin
#1567
Conversation
loicdiridollou
left a comment
loicdiridollou
left a comment
There was a problem hiding this comment.
Nice clean up, minor question on whether it is worth keeping the function that uses the field you have dropped since not documented, open to discussion. Thanks @MarcoGorelli
tests/test_resampler.py
Outdated
| ) -> DataFrame: | ||
| assert isinstance(res, DatetimeIndexResampler) | ||
| return res.obj | ||
| return res.obj # type: ignore[return-value] # pyright: ignore[reportReturnType] |
There was a problem hiding this comment.
Since this is not documented is there a good reason to keep a function like this? The user should not in theory access the field anyway.
tests/test_resampler.py
Outdated
| def k(x: int, t: "DatetimeIndexResampler[DataFrame]") -> DataFrame: | ||
| assert isinstance(x, int) | ||
| return t.obj | ||
| return t.obj # type: ignore[return-value] # pyright: ignore[reportReturnType] |
There was a problem hiding this comment.
Same here, since not documented is there a good reason to keep it? Or could we replace it with a function that use "allowed" fields to keep the same type coverage.
There was a problem hiding this comment.
sure, it's just used here to test pipe so might as well not use obj 👍
There was a problem hiding this comment.
Okay so we can keep it for now
loicdiridollou
left a comment
loicdiridollou
left a comment
There was a problem hiding this comment.
Let's merge this, thanks @MarcoGorelli
2 participants
SelectionMixinis undocumented, and its methods are:obj: undocumentedexclusions: undocumentedndim: undocumented__getitem__: overwritten by subclassesBaseGroupByandBaseWindowaggregate: overwritten by subclassesDataFrameGroupBy,SeriesGroupBy, andBaseWindowCloses #xxxx (Replace xxxx with the Github issue number)
Tests added (Please use
assert_type()to assert the type of any return value)If I used AI to develop this pull request, I prompted it to follow
AGENTS.md.