Replace talk detail bottom sheet with full-screen navigation#418
Open
Replace talk detail bottom sheet with full-screen navigation#418
Conversation
On narrow screens, the session detail was shown as a ModalBottomSheet overlay. This changes it to a regular full-screen push navigation entry with a top bar and back arrow, matching the intent of the main content. - Remove BottomSheetSceneStrategy.bottomSheet() metadata from SessionDetailKey on narrow screens (use emptyMap() instead) - Always show back button and top bar in SessionDetailScreen - Always use LocalNavAnimatedContentScope for animated visibility scope - Remove unused bottomSheetStrategy from NavDisplay.sceneStrategies Agent-Logs-Url: https://github.com/paug/AndroidMakersApp/sessions/fb32d396-6686-453a-a984-e98401f2f5f7 Co-authored-by: benju69 <2486590+benju69@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
benju69
April 8, 2026 19:47
View session
There was a problem hiding this comment.
Pull request overview
Switches talk/session details on narrow screens from a modal bottom sheet to a full-screen navigated destination (with a consistent top app bar + back arrow), while keeping wide-screen list-detail behavior unchanged.
Changes:
- Makes
SessionDetailKeyuse standard navigation on narrow screens by removing bottom-sheet metadata. - Always shows the
SessionDetailScreentop bar and back button (no longer wide-screen only). - Removes
BottomSheetSceneStrategyfromNavDisplayand always providesLocalNavAnimatedContentScopefor shared-element/visibility transitions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benju69
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talk details are the core content of the app — presenting them in a modal bottom sheet undersells their importance and limits screen real estate. Switch to a full-screen destination with a top-bar back arrow on narrow screens, consistent with how speaker details already behave.
Changes
SessionDetailKeyscene strategy: swapBottomSheetSceneStrategy.bottomSheet()foremptyMap()on narrow screens — entry now participates in standard push navigationshowTopBarandshowBackButtonare alwaystrue(no longer gated on wide screen)animatedVisibilityScopeis now alwaysLocalNavAnimatedContentScope.current(wasnullin the overlay path where the scope was unavailable)sceneStrategies:BottomSheetSceneStrategyremoved fromNavDisplay— no remaining entries use itWide-screen list-detail layout is unchanged.