fix(ui): ensure up-to-date upload preview thumbnails in admin panel #15029
+60
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferyto
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
jefferyto
force-pushed
the
fix-ui-upload-thumbnail-imageCacheTag
branch
3 times, most recently
from
a79a908 to
1b09955
Compare
jefferyto
force-pushed
the
fix-ui-upload-thumbnail-imageCacheTag
branch
from
1b09955 to
ccebb24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure the preview thumbnails in list view table cells and edit view upload fields are up-to-date with the actual uploaded/edited images.
Why?
A thumbnail for an uploaded image may be shown in several places:
After editing an image, the thumbnail of the unedited version may still be shown in these places due to browser caching.
How?
This sets the
imageCacheTagproperty for theThumbnailcomponent to force the component to load the latest thumbnail image.Fixes #15027