fix(richtext-lexical): don't reset link drawer form state during lexical updates#16943
Open
harsha-cpp wants to merge 1 commit into
Open
fix(richtext-lexical): don't reset link drawer form state during lexical updates#16943harsha-cpp wants to merge 1 commit into
harsha-cpp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15719.
problem: autosave triggers a lexical state update, which calls
$updateLinkEditor, which callssetStateData(data)with the node's committed fields.DrawerContenthasdatain itsuseEffectdependency array, so every update re-fetches the initial form state — reverting any in-progress edits (e.g. switching link type from custom to internal) back to what's persisted in the lexical node.fix: expose
isOpenfromuseLexicalDrawerand guardsetStateDatain$updateLinkEditor. when the drawer is already open, lexical updates no longer overwrite the form's initial state; the drawer only resets when it opens fresh for a new link.