Skip to content

Update import.php and add new option#503

Open
rotelok wants to merge 1 commit into
perftools:0.23.xfrom
rotelok:update-importer-to-accept-a-directory
Open

Update import.php and add new option#503
rotelok wants to merge 1 commit into
perftools:0.23.xfrom
rotelok:update-importer-to-accept-a-directory

Conversation

@rotelok
Copy link
Copy Markdown

@rotelok rotelok commented Jan 16, 2025

added a new option -d to get all files ending in .jsonl from a directory and make a batch import

added a new option -d to get all files ending in .jsonl from a directory and make a batch import
@glensc
Copy link
Copy Markdown
Contributor

glensc commented Jan 20, 2025

too many changes in one pr. one change per pr change please

@glensc
Copy link
Copy Markdown
Contributor

glensc commented Jan 20, 2025

also, this file is deprecated

the new way is in php-profiler project:

Comment thread external/import.php

if (!isset($options['f'])) {
throw new InvalidArgumentException('You should define a file to be loaded');
var_dump($options);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug. must be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants