-
Notifications
You must be signed in to change notification settings - Fork 13
[change] use perses/spec in shared component #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
985f804
4a06076
604c519
f118aa0
0ebff31
6259cda
e438f55
21d155f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ | |
|
|
||
| import { Button, Divider, Stack, StackProps } from '@mui/material'; | ||
| import { ReactElement } from 'react'; | ||
| import { Action } from '@perses-dev/core'; | ||
| import { Action } from '@perses-dev/core'; // TODO the internal permission system of Perses should not be in a shared library | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question, |
||
|
|
||
| export interface FormActionsProps extends StackProps { | ||
| action: Action; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ | |
|
|
||
| import { render, screen } from '@testing-library/react'; | ||
| import userEvent from '@testing-library/user-event'; | ||
| import { FormatOptions } from '@perses-dev/core'; | ||
| import { FormatOptions } from '@perses-dev/core'; // TODO | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| import { FormatControls } from './FormatControls'; | ||
|
|
||
| describe('FormatControls', () => { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question,
You have put a comment TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so everything that was required to move to
spechas been moved. So, excepting if I missed something, there won't anything else to put in thespecrepo.The todo is there to decide what we should do about this import. Do we need to change the code to avoid this import ? Do we need to move the code imported in another package in the
sharedrepository.For each import, these questions are relevant. I have already assessed for some import what to do.
These efforts and questions are part of the cleaning work to be done to have a clear API for the embedding feature.