Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"@fontsource/lato": "^4.5.10",
"@mui/x-date-pickers": "^7.23.1",
"@perses-dev/core": "0.53.0",
"@perses-dev/spec": "0.2.0-beta.0",
"@tanstack/react-table": "^8.20.5",
"@uiw/react-codemirror": "^4.19.1",
"date-fns": "^4.1.0",
Expand Down
2 changes: 1 addition & 1 deletion components/src/ContentWithLegend/ContentWithLegend.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import { ReactElement } from 'react';
import { Box, useTheme } from '@mui/material';
import { getLegendSize } from '@perses-dev/core';
import { getLegendSize } from '@perses-dev/core'; // TODO
import { Legend } from '../Legend';
import { ContentWithLegendProps, getContentWithLegendLayout } from './model/content-with-legend-model';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// limitations under the License.

import { createTheme } from '@mui/material';
import { legendModes, legendSizes } from '@perses-dev/core';
import { legendModes, legendSizes } from '@perses-dev/core'; // TODO
import * as table from '../../Table';
Comment on lines +15 to 16
Copy link
Copy Markdown
Contributor

@shahrokni shahrokni Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question,
You have put a comment TODO.

  • Does TODO mean that these will be later exposed from Spec and should be imported from there?
  • If the first question is valid, then, Do we have any plans to move legend.ts to the Spec and expose it from there? If yes, is there any reason that we have not done it yet?
  • Again if the first question is valid, shouldn't we first move everything (those which make sense to be in Spec) to the Spec, and then clean the shared?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so everything that was required to move to spec has been moved. So, excepting if I missed something, there won't anything else to put in the spec repo.

The todo is there to decide what we should do about this import. Do we need to change the code to avoid this import ? Do we need to move the code imported in another package in the shared repository.

For each import, these questions are relevant. I have already assessed for some import what to do.

These efforts and questions are part of the cleaning work to be done to have a clear API for the embedding feature.

import {
ContentWithLegendLayoutOpts,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// limitations under the License.

import { Theme } from '@mui/material';
import { LegendPositions, getLegendMode, LegendSize } from '@perses-dev/core';
import { LegendPositions, getLegendMode, LegendSize } from '@perses-dev/core'; //TODO
import { LegendProps } from '../../Legend';
import { getTableCellLayout } from '../../Table';

Expand Down
2 changes: 1 addition & 1 deletion components/src/FormEditor/FormActions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import { Button, Divider, Stack, StackProps } from '@mui/material';
import { ReactElement } from 'react';
import { Action } from '@perses-dev/core';
import { Action } from '@perses-dev/core'; // TODO the internal permission system of Perses should not be in a shared library
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question,
Since I am working on the Core at the same time,
As long as members of roles.ts are exposed from Core, they might be misused by dependent packages.
If internal stuff of Perses must stay in the Perses, shouldn't we move roles.ts members to ui/app?
And if we do that, then it will be a breaking change. Are we OK with that?


export interface FormActionsProps extends StackProps {
action: Action;
Expand Down
2 changes: 1 addition & 1 deletion components/src/FormatControls/FormatControls.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import { render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { FormatOptions } from '@perses-dev/core';
import { FormatOptions } from '@perses-dev/core'; // TODO
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { FormatControls } from './FormatControls';

describe('FormatControls', () => {
Expand Down
2 changes: 1 addition & 1 deletion components/src/FormatControls/FormatControls.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
import { Switch, SwitchProps } from '@mui/material';
import { FormatOptions, isUnitWithDecimalPlaces, isUnitWithShortValues, shouldShortenValues } from '@perses-dev/core';
import { FormatOptions, isUnitWithDecimalPlaces, isUnitWithShortValues, shouldShortenValues } from '@perses-dev/core'; // TODO
import { ReactElement } from 'react';
import { OptionsEditorControl } from '../OptionsEditorLayout';
import { SettingsAutocomplete } from '../SettingsAutocomplete';
Expand Down
2 changes: 1 addition & 1 deletion components/src/FormatControls/UnitSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { FormatOptions, UNIT_CONFIG, UnitConfig } from '@perses-dev/core';
import { FormatOptions, UNIT_CONFIG, UnitConfig } from '@perses-dev/core'; // TODO
import { ReactElement } from 'react';
import { SettingsAutocomplete } from '../SettingsAutocomplete';

Expand Down
2 changes: 1 addition & 1 deletion components/src/Legend/Legend.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import { Box } from '@mui/material';
import { produce } from 'immer';
import { ReactElement, ReactNode } from 'react';
import { getLegendMode } from '@perses-dev/core';
import { getLegendMode } from '@perses-dev/core'; // TODO
import { ListLegend } from './ListLegend';
import { CompactLegend } from './CompactLegend';
import { TableLegend, TableLegendProps } from './TableLegend';
Expand Down
2 changes: 1 addition & 1 deletion components/src/Legend/legend-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// limitations under the License.

import { MouseEventHandler } from 'react';
import { LegendOptionsBase } from '@perses-dev/core';
import { LegendOptionsBase } from '@perses-dev/core'; // TODO

// This file contains legend-related model code specific to the legend component.
// See the `core` package for common/shared legend model code and the
Expand Down
2 changes: 1 addition & 1 deletion components/src/LinksEditor/LinksEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { Divider, IconButton, Stack, Typography } from '@mui/material';
import { Controller, useFieldArray, Control } from 'react-hook-form';
import PlusIcon from 'mdi-material-ui/Plus';
import MinusIcon from 'mdi-material-ui/Minus';
import { PanelEditorValues } from '@perses-dev/core';
import { PanelEditorValues } from '@perses-dev/spec';
import { LinkEditorForm } from './LinkEditorForm';

export interface LinksEditorProps extends HTMLAttributes<HTMLDivElement> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// limitations under the License.

import { Box, FormControl, MenuItem, Select } from '@mui/material';
import { DurationString } from '@perses-dev/core';
import { DurationString } from '@perses-dev/spec';
import { ReactElement, useMemo } from 'react';
import { TimeOption } from '../model';

Expand Down
2 changes: 1 addition & 1 deletion components/src/Table/model/table-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// limitations under the License.

import { Theme } from '@mui/material';
import { Link } from '@perses-dev/core';
import { Link } from '@perses-dev/spec';
import {
AccessorKeyColumnDef,
CellContext,
Expand Down
2 changes: 1 addition & 1 deletion components/src/ThresholdsEditor/ThresholdInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import { ReactElement, RefObject, useState } from 'react';
import { Stack, FormLabel, TextField, IconButton, Box } from '@mui/material';
import DeleteIcon from 'mdi-material-ui/DeleteOutline';
import { ThresholdOptions } from '@perses-dev/core';
import { ThresholdOptions } from '@perses-dev/core'; // TODO
import { OptionsColorPicker } from '../ColorPicker/OptionsColorPicker';

export interface ThresholdInputProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { ThresholdOptions } from '@perses-dev/core';
import { ThresholdOptions } from '@perses-dev/core'; // TODO
import { render, screen, waitFor } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { produce } from 'immer';
Expand Down
2 changes: 1 addition & 1 deletion components/src/ThresholdsEditor/ThresholdsEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { produce } from 'immer';
import { IconButton, ToggleButton, ToggleButtonGroup, Typography } from '@mui/material';
import PlusIcon from 'mdi-material-ui/Plus';
import { Stack } from '@mui/system';
import { ThresholdOptions } from '@perses-dev/core';
import { ThresholdOptions } from '@perses-dev/core'; // TODO
import { useChartsTheme } from '../context/ChartsProvider';
import { OptionsEditorControl, OptionsEditorGroup } from '../OptionsEditorLayout';
import { InfoTooltip } from '../InfoTooltip';
Expand Down
2 changes: 1 addition & 1 deletion components/src/TimeRangeSelector/DateTimeRangePicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { ReactElement, useState } from 'react';
import { Box, Stack, Typography, Button } from '@mui/material';
import { DateTimeField, LocalizationProvider, StaticDateTimePicker } from '@mui/x-date-pickers';
import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFnsV3';
import { AbsoluteTimeRange } from '@perses-dev/core';
import { AbsoluteTimeRange } from '@perses-dev/spec';
import { TZDate } from '@date-fns/tz';
import { ErrorBoundary } from '../ErrorBoundary';
import { ErrorAlert } from '../ErrorAlert';
Expand Down
2 changes: 1 addition & 1 deletion components/src/TimeRangeSelector/TimeRangeSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import { Box, MenuItem, Popover, Select, IconButton, TextField } from '@mui/material';
import Calendar from 'mdi-material-ui/Calendar';
import EarthIcon from 'mdi-material-ui/Earth';
import { TimeRangeValue, isRelativeTimeRange, AbsoluteTimeRange, toAbsoluteTimeRange } from '@perses-dev/core';
import { TimeRangeValue, isRelativeTimeRange, AbsoluteTimeRange, toAbsoluteTimeRange } from '@perses-dev/spec';
import { ReactElement, useMemo, useRef, useState } from 'react';
import { useTimeZone } from '../context';
import { TimeZoneOption, getTimeZoneOptions } from '../model/timeZoneOption';
Expand Down
2 changes: 1 addition & 1 deletion components/src/TimeRangeSelector/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// limitations under the License.

import { isBefore, isValid } from 'date-fns';
import { AbsoluteTimeRange, isRelativeTimeRange, TimeRangeValue } from '@perses-dev/core';
import { AbsoluteTimeRange, isRelativeTimeRange, TimeRangeValue } from '@perses-dev/spec';
import { formatWithTimeZone } from '../utils';

export const DATE_TIME_FORMAT = 'yyyy-MM-dd HH:mm:ss';
Expand Down
3 changes: 2 additions & 1 deletion components/src/TimeSeriesTooltip/TimeChartTooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
import { memo, MutableRefObject, useRef, useState } from 'react';
import { Box, Portal, Stack } from '@mui/material';
import { ECharts as EChartsInstance } from 'echarts/core';
import { FormatOptions, TimeSeries } from '@perses-dev/core';
import { FormatOptions } from '@perses-dev/core'; // TODO
import { TimeSeries } from '@perses-dev/spec';
import useResizeObserver from 'use-resize-observer';
import { TimeChartSeriesMapping } from '../model';
import { CursorCoordinates, useMousePosition } from './tooltip-model';
Expand Down
2 changes: 1 addition & 1 deletion components/src/TimeSeriesTooltip/nearby-series.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { FormatOptions } from '@perses-dev/core';
import { FormatOptions } from '@perses-dev/core'; // TODO
import { EChartsDataFormat } from '../model';
import { legacyCheckforNearbySeries, getYBuffer, isWithinPercentageRange } from './nearby-series';

Expand Down
2 changes: 1 addition & 1 deletion components/src/TimeSeriesTooltip/nearby-series.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import { ECharts as EChartsInstance } from 'echarts/core';
import { LineSeriesOption } from 'echarts/charts';
import { formatValue, TimeSeriesValueTuple, FormatOptions, TimeSeries } from '@perses-dev/core';
import { formatValue, TimeSeriesValueTuple, FormatOptions, TimeSeries } from '@perses-dev/core'; // TODO
import { EChartsDataFormat, OPTIMIZED_MODE_SERIES_LIMIT, TimeChartSeriesMapping, DatapointInfo } from '../model';
import { batchDispatchNearbySeriesActions, getPointInGrid, getClosestTimestamp } from '../utils';
import { CursorCoordinates, CursorData, EMPTY_TOOLTIP_DATA } from './tooltip-model';
Expand Down
2 changes: 1 addition & 1 deletion components/src/TransformsEditor/TransformEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {
MergeIndexedColumnsTransform,
MergeSeriesTransform,
Transform,
} from '@perses-dev/core';
} from '@perses-dev/core'; // TODO
import { ReactElement } from 'react';
import { TextField } from '../controls';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import ChevronDown from 'mdi-material-ui/ChevronDown';
import EyeOffIcon from 'mdi-material-ui/EyeOffOutline';
import EyeIcon from 'mdi-material-ui/EyeOutline';
import DeleteIcon from 'mdi-material-ui/DeleteOutline';
import { Transform, TRANSFORM_TEXT } from '@perses-dev/core';
import { Transform, TRANSFORM_TEXT } from '@perses-dev/core'; // TODO
import { ReactElement } from 'react';
import { TransformEditor, TransformEditorProps } from './TransformEditor';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import { render, screen, fireEvent } from '@testing-library/react';
import { TransformsEditor } from '@perses-dev/components';
import { Transform } from '@perses-dev/core';
import { Transform } from '@perses-dev/core'; // TODO

describe('TransformsEditor', () => {
function renderTableColumnsEditor(value: Transform[], onChange = jest.fn()): void {
Expand Down
2 changes: 1 addition & 1 deletion components/src/TransformsEditor/TransformsEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { Transform } from '@perses-dev/core';
import { Transform } from '@perses-dev/core'; // TODO
import { Button, Stack, StackProps } from '@mui/material';
import { ReactElement, useState } from 'react';
import AddIcon from 'mdi-material-ui/Plus';
Expand Down
2 changes: 1 addition & 1 deletion components/src/ValueMappingEditor/ValueMappingEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import {
} from '@mui/material';
import DeleteIcon from 'mdi-material-ui/DeleteOutline';
import PlusIcon from 'mdi-material-ui/Plus';
import { ValueMapping } from '@perses-dev/core';
import { ValueMapping } from '@perses-dev/core'; // TODO
import { FC } from 'react';
import { OptionsColorPicker } from '../ColorPicker/OptionsColorPicker';

Expand Down
3 changes: 1 addition & 2 deletions components/src/ValueMappingEditor/ValueMappingsEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@
// limitations under the License.

import { Button, Divider, Stack, Typography, Grid2 as Grid } from '@mui/material';

import { FC, useState } from 'react';
import AddIcon from 'mdi-material-ui/Plus';
import { ValueMapping } from '@perses-dev/core';
import { ValueMapping } from '@perses-dev/core'; // TODO
import { ValueMappingEditor } from './ValueMappingEditor';

export interface ValueMappingsEditorProps {
Expand Down
2 changes: 1 addition & 1 deletion components/src/model/graph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { TimeSeriesValueTuple } from '@perses-dev/core';
import { TimeSeriesValueTuple } from '@perses-dev/spec';
import { LineSeriesOption, BarSeriesOption } from 'echarts/charts';
import { LegendItem } from '../Legend';

Expand Down
2 changes: 1 addition & 1 deletion components/src/model/theme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { ThresholdColorPalette } from '@perses-dev/core';
import { ThresholdColorPalette } from '@perses-dev/core'; // TODO
import type {
EChartsOption,
BarSeriesOption,
Expand Down
2 changes: 1 addition & 1 deletion components/src/model/timeOption.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { DurationString, parseDurationString, RelativeTimeRange } from '@perses-dev/core';
import { DurationString, parseDurationString, RelativeTimeRange } from '@perses-dev/spec';
import { formatDuration } from 'date-fns';

export interface TimeOption {
Expand Down
2 changes: 1 addition & 1 deletion components/src/utils/axis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import merge from 'lodash/merge';
import type { XAXisComponentOption, YAXisComponentOption } from 'echarts';
import { formatValue, FormatOptions } from '@perses-dev/core';
import { formatValue, FormatOptions } from '@perses-dev/core'; // TODO

export interface YAxisConfig {
format?: FormatOptions;
Expand Down
2 changes: 1 addition & 1 deletion components/src/utils/chart-actions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { TimeSeries, TimeSeriesValueTuple } from '@perses-dev/core';
import { TimeSeries, TimeSeriesValueTuple } from '@perses-dev/spec';
import { getClosestTimestamp, getClosestTimestampInFullDataset } from './chart-actions';

const TEST_TIME_SERIES_VALUES: TimeSeriesValueTuple[] = [
Expand Down
2 changes: 1 addition & 1 deletion components/src/utils/chart-actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// limitations under the License.

import { ECharts as EChartsInstance } from 'echarts/core';
import { TimeSeries, TimeSeriesValueTuple } from '@perses-dev/core';
import { TimeSeries, TimeSeriesValueTuple } from '@perses-dev/spec';
import { DatapointInfo, PINNED_CROSSHAIR_SERIES_NAME, TimeChartSeriesMapping } from '../model';

export interface ZoomEventData {
Expand Down
2 changes: 1 addition & 1 deletion components/src/utils/variable-interpolation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { VariableValue } from '@perses-dev/core';
import { VariableValue } from '@perses-dev/spec';

/**
* Option for a variable with label and value
Expand Down
1 change: 1 addition & 0 deletions dashboards/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"@perses-dev/components": "0.53.1",
"@perses-dev/core": "0.53.0",
"@perses-dev/plugin-system": "0.53.1",
"@perses-dev/spec": "0.2.0-beta.0",
"@types/react-grid-layout": "^1.3.2",
"date-fns": "^4.1.0",
"immer": "^10.1.1",
Expand Down
1 change: 1 addition & 0 deletions dashboards/src/components/Dashboard/Dashboard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { usePanelGroupIds } from '../../context';
import { GridLayout } from '../GridLayout';
import { EmptyDashboard, EmptyDashboardProps } from '../EmptyDashboard';
import { PanelOptions } from '../Panel';

export type DashboardProps = BoxProps & {
/**
* Props for `EmptyDashboard` component that will be rendered when the dashboard
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import ArrowUp from 'mdi-material-ui/ArrowUp';
import ArrowDown from 'mdi-material-ui/ArrowDown';
import PencilIcon from 'mdi-material-ui/Pencil';
import ChevronUp from 'mdi-material-ui/ChevronUp';
import { Link } from '@perses-dev/core';
import { Link } from '@perses-dev/spec';
import { useImmer } from 'use-immer';
import { InfoTooltip, LinkEditorForm } from '@perses-dev/components';
import { useDiscardChangesConfirmationDialog } from '../../context';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { ReactElement, useState } from 'react';
import { Button, ButtonProps } from '@mui/material';
import PencilIcon from 'mdi-material-ui/PencilOutline';
import { Drawer, InfoTooltip } from '@perses-dev/components';
import { Link } from '@perses-dev/core';
import { Link } from '@perses-dev/spec';
import { TOOLTIP_TEXT, editButtonStyle } from '../../constants';
import { useDashboardLinks, useDashboardLinksActions } from '../../context';
import { DashboardLinksEditor } from './DashboardLinksEditor';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ import {
import AddIcon from 'mdi-material-ui/Plus';
import PencilIcon from 'mdi-material-ui/Pencil';
import TrashIcon from 'mdi-material-ui/TrashCan';
import { Action, DatasourceDefinition, DatasourceSpec } from '@perses-dev/core';
import { Action, DatasourceDefinition } from '@perses-dev/core'; // TODO
import { DatasourceSpec } from '@perses-dev/spec';
import { DatasourceEditorForm, ValidationProvider } from '@perses-dev/plugin-system';
import { ReactElement, useState } from 'react';
import { useImmer } from 'use-immer';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import { ReactElement, useState } from 'react';
import { Button } from '@mui/material';
import PencilIcon from 'mdi-material-ui/PencilOutline';
import { Drawer, InfoTooltip } from '@perses-dev/components';
import { DashboardResource, DatasourceSpec, EphemeralDashboardResource } from '@perses-dev/core';
import { DashboardResource, EphemeralDashboardResource } from '@perses-dev/core'; // TODO weird that ephemeral dashboard is required here
import { DatasourceSpec } from '@perses-dev/spec';
import { useDatasourceStore } from '@perses-dev/plugin-system';
import { TOOLTIP_TEXT, editButtonStyle } from '../../constants';
import { useDashboard } from '../../context';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { DashboardResource, EphemeralDashboardResource } from '@perses-dev/core';
import { DashboardResource, EphemeralDashboardResource } from '@perses-dev/core'; // TODO metadata should not be used, same for ephemeral dashboard
import { stringify } from 'yaml';

type SerializedDashboard = {
Expand Down
2 changes: 1 addition & 1 deletion dashboards/src/components/GridLayout/GridItemContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { Box } from '@mui/material';
import { useInView } from 'react-intersection-observer';
import { DataQueriesProvider, usePlugin, useSuggestedStepMs } from '@perses-dev/plugin-system';
import React, { ReactElement, useMemo, useState } from 'react';
import { isPanelGroupItemIdEqual, PanelGroupItemId } from '@perses-dev/core';
import { isPanelGroupItemIdEqual, PanelGroupItemId } from '@perses-dev/core'; // TODO
import { useEditMode, usePanel, usePanelActions, useViewPanelGroup } from '../../context';
import { Panel, PanelProps, PanelOptions } from '../Panel';
import { QueryViewerDialog } from '../QueryViewerDialog';
Expand Down
3 changes: 2 additions & 1 deletion dashboards/src/components/GridLayout/GridLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
// limitations under the License.
import { ReactElement, useState } from 'react';
import { Layouts, Layout } from 'react-grid-layout';
import { PanelGroupId, PanelGroupDefinition } from '@perses-dev/core';
import { PanelGroupDefinition } from '@perses-dev/core'; // TODO what should we do about the PanelGroupDefinition ?
import { PanelGroupId } from '@perses-dev/spec';
import { useVariableValues, VariableContext } from '@perses-dev/plugin-system';
import { useEditMode, usePanelGroup, usePanelGroupActions, useViewPanelGroup } from '../../context';
import { GRID_LAYOUT_SMALL_BREAKPOINT } from '../../constants';
Expand Down
Loading
Loading