fix(datagrid): persist column widths in columns config - #3215
Open
LarryHu0217 wants to merge 2 commits into
Open
fix(datagrid): persist column widths in columns config#3215LarryHu0217 wants to merge 2 commits into
LarryHu0217 wants to merge 2 commits into
Conversation
Signed-off-by: Liang Hu <35699841+LarryHu0217@users.noreply.github.com>
Signed-off-by: Liang Hu <35699841+LarryHu0217@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Column widths are column-level style state, so this change moves their persistence to
ViewerConfig.columns_config.column_size_overridethrough the Datagrid column config schemacolumns_configwhile preserving other column stylesplugin_configsplit_byis populatedCloses #3163.
Validation
git diff --checkThe full Playwright test was not run locally because this checkout does not have the generated client/viewer WASM artifacts; the regression tests are included for CI.
AI assistance
I used OpenAI Codex to help inspect the codebase, implement the change, draft the regression tests, and run the local checks. I reviewed the final diff and validation results myself.