Change the socket default for longpoll back to false - #6487
Merged
SteffenDE merged 1 commit intoSep 23, 2025
Merged
Conversation
Member
|
Thank you @gpedic, it was a mistake and we should have caught it in code review! |
zekedou
added a commit
to combo-lab/combo
that referenced
this pull request
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default for
longpollwas changed totruefor no apparent reason by this PR #6072 about 7 months ago.This can and has caused issues for us after updating Phoenix as we didn't expect
longpollto become enabled.The default was
falsebefore since forever and still is inPhoenix.Socket, and is documented as such in thePhoenix.Endpointdocs.The specific issue we ran into was that our sockets websocket was configured with session options while longpoll was not configured at all since it was not enabled previously. Every time the connection would fall back to longpoll it would fail to connect due to missing the session information. This would only happen from time to time so was an elusive issue track down.
I would propose changing the default back to
falseas I think that is the expected behavior, unless there is a strong reason not to.