Draft
Conversation
This is a naive approach for a parse_float() that was implemented in Tokay already. See the comment in float.rs for details on how this isn't the best.
Still not equal to Rust's f64 literals, yet.
Still not perfect - the rounding glitches.
phorward
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should add support for floating point numbers to the
num-parse-crate.The branch is already open for a while, and there is a problem with the precision, which shall be equal to the one reached by Rust directly.
The problem is this test, where
-1337.0e-298f64works but-1337.0e-299f64fails in precision (assertion left == right failed; left: Some(-1.3369999999999998e-296); right: Some(-1.337e-296))