Skip to content

Fix #124 Require parenthesis around clone() #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbeccati wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Fix #124 Require parenthesis around clone() #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,16 @@ die();
$result = foo() ?? exit();
```

The `clone` language construct MUST always be used with parenthesis, even when the optional `$withProperties` argument is
not provided. For example:
Copy link
Copy Markdown
Author

@mbeccati mbeccati May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrfnl How about something along the lines of

Suggested change
not provided. For example:
not provided. As such, it follows the same rules as function calls. For example:

Copy link
Copy Markdown
Contributor

@jrfnl jrfnl May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it needs to be spelled out as this paragraph is within the "function and method call" section anyway, but I just wanted to clarify to avoid ending up with discussions about this in the PHPCS repo later on.


```php
$b = clone($a);
$b = clone($a, [
'foo' => 'bar',
]);
```

### 4.8 Function Callable References

A function or method may be referenced in a way that creates a closure out of it, by providing `...` in place of arguments.
Expand Down