Update LuaSandbox installation method - #5725
Open
tstarling wants to merge 1 commit into
Open
Conversation
New releases will be in PIE and Debian.
tstarling
force-pushed
the
luasandbox-pie
branch
from
July 30, 2026 04:42
7f192a9 to
5bb92e1
Compare
jordikroon
requested changes
Jul 30, 2026
| </para> | ||
|
|
||
| <para> | ||
| To install LuaSandbox using <link xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="https://github.com/php/pie">PIE</link>, |
Member
There was a problem hiding this comment.
Please use the &url.pie; entity reference for href.
| </programlisting> | ||
| </para> | ||
|
|
||
| <simpara> |
Member
There was a problem hiding this comment.
Should we make this a note instead?
Also I think it's more consistent with the docs if we don't include "the" in the url.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New releases will be in PIE and Debian.
MongoDB seemed to be the nearest analogy, but what we need to say here is a lot simpler, so I pared it down to a single section. I used
programlistingfor the shell commands, as in MongoDB.