ext/reflection: various cleanups and simplifications (2)#22660
Open
DanielEScherzer wants to merge 10 commits into
Open
ext/reflection: various cleanups and simplifications (2)#22660DanielEScherzer wants to merge 10 commits into
DanielEScherzer wants to merge 10 commits into
Conversation
Girgias
reviewed
Jul 10, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Did the review commit by commit. And found some orthogonal issues that can be fixed here or in a follow-up PR.
Comment on lines
+980
to
988
| if (!prop) { | ||
| // Dynamic property, known to have no doc comment, flags, etc. | ||
| smart_str_append_printf(str, "%sProperty [ <dynamic> public $%s ]\n", indent, prop_name); | ||
| return; | ||
| } | ||
| if (prop->doc_comment) { | ||
| smart_str_append_printf(str, "%s%s\n", indent, ZSTR_VAL(prop->doc_comment)); | ||
| } | ||
| smart_str_append_printf(str, "%sProperty [ ", indent); |
Member
There was a problem hiding this comment.
Would it make sense to have a smart_str_appends(str, indent); call before either of the smart_str_append_printf(), as I'm not really the biggest fan of the printf variants personally. But no big opinion here.
Comment on lines
+2409
to
+2410
| zval *object = ZEND_THIS; | ||
| reflection_object *intern = Z_REFLECTION_P(object); |
Member
There was a problem hiding this comment.
Is the object zval even used somewhere else? Might be better to just do Z_REFLECTION_P(ZEND_THIS);
| if (ini_entry->modifiable == ZEND_INI_ALL) { | ||
| smart_str_appends(str, "ALL"); | ||
| } else { | ||
| char *comma = ""; |
| } | ||
|
|
||
| zval *params; | ||
| int num_args; |
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| int argc = 0; |
Comment on lines
+7402
to
7403
| zend_class_entry *ce; | ||
| if (NULL == (ce = zend_lookup_class(attr->data->name))) { |
Member
There was a problem hiding this comment.
Could be rewritten as:
zend_class_entry *ce = zend_lookup_class(attr->data->name);
if (ce == NULL) {
Comment on lines
+5340
to
+5341
| zend_string *mname = zend_string_alloc(ZSTR_LEN(class_name) + ZSTR_LEN(cur_ref->method_name) + 2, false); | ||
| snprintf(ZSTR_VAL(mname), ZSTR_LEN(mname) + 1, "%s::%s", ZSTR_VAL(class_name), ZSTR_VAL(cur_ref->method_name)); |
Member
There was a problem hiding this comment.
Aside: This feels this would be safer if it was a simple zend_strpprintf.
Optimize - `ReflectionParameter::__construct()` - `ReflectionClass::getMethods()` Given that the `Closure` class is declared as `final`, for some class entry `ce` to represent an instance of a `Closure` it must be exactly `zend_ce_closure`. Replace the `instanceof_function()` call with a simple pointer comparison.
While different callers provided different levels of indentation to the function, the indentation was never used. Remove the parameter and update callers.
…mon` Internal and userland functions store their documentation comments the same way, as a `zend_string` pointer. These pointers are part of the common elements at the start of both `zend_op_array` and `zend_internal_function` that are made available via `zend_function.common`; use the common access rather than checking for the different types of functions individually.
…ng()` For dynamic properties all of the representation details are known immediately, skip the checks for comments, flags, types, defaults, and hooks and use an early return.
When a variable has a single consistent initialization location, move the declaration to be combined with the initialization.
Move variable declarations into the loop start macro where possible to have the types of the variables clear in the loop.
If they cannot be declared at the point of initialization, at least move the declarations closer to where the variables are used.
Consistently indent with tabs, split up some long lines, combine some nested conditions, and overall try to improve readability.
DanielEScherzer
force-pushed
the
reflection-cleanup-202607-r2
branch
from
6e5dc76 to
54d8366
Compare
Member
Author
|
Rebased and updated for some of the comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.