Skip to content

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Jan 14, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. labels Jan 14, 2026
@hfxsd hfxsd self-assigned this Jan 14, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity and completeness of the documentation for the TIDB_ENCODE_INDEX_KEY and TIDB_ENCODE_RECORD_KEY functions. The changes provide explicit syntax, detailed parameter descriptions, and illustrative examples, particularly clarifying how different primary key types influence the handle_columns argument. This enhancement aims to help users better understand and correctly utilize these TiDB functions.

Highlights

  • Enhanced TIDB_ENCODE_INDEX_KEY Documentation: The documentation for TIDB_ENCODE_INDEX_KEY has been significantly expanded to include its full syntax, detailed explanations for each parameter (including db_name, table_name, index_name, index_columns, and handle_columns), and specific rules for determining handle_columns based on primary key types (e.g., _tidb_rowid, single integer CLUSTERED, composite CLUSTERED).
  • New Examples for TIDB_ENCODE_INDEX_KEY: Several new SQL examples have been added to illustrate the usage of TIDB_ENCODE_INDEX_KEY with composite secondary indexes and different primary key configurations, making its application clearer for users.
  • Improved TIDB_ENCODE_RECORD_KEY Documentation: The TIDB_ENCODE_RECORD_KEY function's documentation now includes its syntax and detailed parameter descriptions, with a clear reference to the comprehensive handle_columns explanation provided for TIDB_ENCODE_INDEX_KEY.
  • Example Data Consistency: Minor updates were made to example INSERT statements and SELECT calls for both functions to ensure consistency and accuracy in the provided code snippets.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2026
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2026
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2026
@hfxsd hfxsd requested a review from wjhuang2016 January 14, 2026 10:48
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly clarifies the parameters for the TIDB_ENCODE_INDEX_KEY and TIDB_ENCODE_RECORD_KEY functions, which is a great improvement for the documentation. My review includes a few minor suggestions to enhance readability and consistency, such as using consistent list formatting and making descriptions more concise.

@hfxsd hfxsd requested a review from Oreoxmt January 15, 2026 00:55
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 15, 2026

@fzzf678: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 19, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-19 03:50:45.108391449 +0000 UTC m=+379472.722348306: ☑️ agreed by Oreoxmt.

@hfxsd hfxsd added lgtm and removed contribution This PR is from a community contributor. labels Jan 19, 2026
@hfxsd
Copy link
Collaborator Author

hfxsd commented Jan 19, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2026
@ti-chi-bot ti-chi-bot bot merged commit ba59f2a into pingcap:master Jan 19, 2026
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22344.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants