explain-joins: reword "create ... on disk" as "spill ... to disk" (#23346) - #23755
explain-joins: reword "create ... on disk" as "spill ... to disk" (#23346)#23755ti-chi-bot wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe hash join documentation now describes spilling data from the Build side to disk when ChangesHash Join Documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This documentation-only update clarifies hash join disk spilling behavior without changing runtime behavior or configuration. It is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This is an automated cherry-pick of #23346
What is changed, added or deleted? (Required)
In the Hash Join section of
explain-joins.md, one sentence describes the on-disk behavior as:"create the
Buildoperator on disk" is confusing — the operator is not created on disk; its data is spilled to temporary storage. Later on the same page, the system-variables section already describes the same behavior with clearer wording:This PR aligns the earlier sentence with that clearer, consistent wording ("spill ... to disk").
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
N/A — documentation wording clarification.
🤖 Generated with Claude Code
Summary by CodeRabbit