Skip to content

migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database (#23700) - #23756

Open
ti-chi-bot wants to merge 3 commits into
pingcap:masterfrom
ti-chi-bot:cherry-pick-23700-to-master
Open

migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database (#23700)#23756
ti-chi-bot wants to merge 3 commits into
pingcap:masterfrom
ti-chi-bot:cherry-pick-23700-to-master

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #23700

What is changed, added or deleted? (Required)

The doc listed test alongside INFORMATION_SCHEMA, PERFORMANCE_SCHEMA, mysql, and sys under the label "system databases". test is a default user database TiDB/MySQL creates for convenience, not a system (metadata) database like the other four. Reworded the shared label to "default databases", which accurately covers all five entries without changing the practical guidance (still filter out all five when setting up an AWS DMS migration task).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (LTS)

Do your changes match any of the following descriptions? (Required)

  • Delete files in the markdown-pages repository
  • Change the directory
  • Need modification after machine translation
  • Screenshots or GIFs are included in the changes

Summary by CodeRabbit

  • Documentation
    • Updated the AWS DMS migration guide to recommend explicitly selecting only the databases and tables intended for migration.
    • Clarified that using the default % wildcard may include MySQL system databases and cause the migration task to fail.

yahonda and others added 3 commits September 7, 2026 02:25
…atabase

`test` is a default user database, not a system database (unlike
INFORMATION_SCHEMA, PERFORMANCE_SCHEMA, mysql, and sys). Reword to
"default databases" so the list's shared label is accurate for all
five entries.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot added lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. labels Sep 7, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackysp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 22a4913d-9e6a-4a6f-87c9-593c441d0630

📥 Commits

Reviewing files that changed from the base of the PR and between f83b80b and d777efc.

📒 Files selected for processing (1)
  • tidb-cloud/migrate-from-mysql-using-aws-dms.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants