Skip to content

i18n(ja): restore literal quoted status/enum values in DM docs - #23758

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-quoted-literal-status-values-japanese
Open

i18n(ja): restore literal quoted status/enum values in DM docs#23758
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-quoted-literal-status-values-japanese

Conversation

@yahonda

@yahonda yahonda commented Sep 7, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Found while investigating a similar literal-value defect on PR #23635. In dm/dm-query-status.md and dm/dm-continuous-data-validation.md, several quoted literal status/enum values that DM's query-status/validation commands actually return (or that a user matches against verbatim) had been translated into Japanese and re-quoted with full-width corner brackets (「」) instead of being kept as the literal English string in double quotes (""), matching the EN source:

  • dm/dm-query-status.md: "stage"/"subTaskStatus"/"sources"/"unresolvedDDLLockID" (JSON field names) and "Check"/"Dump"/"Load"/"Sync" (DM processing unit names) — mistranslated as 「stage」-style corner-bracketed Japanese; also "synced" (subtask status value) mistranslated as 「同期済み」.
  • dm/dm-continuous-data-validation.md: "ignored", "resolved", and "expired" (validation error-row/data status values) mistranslated as 「無視」, 「解決済み」, 「期限切れ」.

All fixes verified against the English source on release-8.5, and use straight double quotes ("") matching EN, not Japanese corner brackets.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated Japanese documentation terminology with consistent English quoted labels, including "ignored", "resolved", and "expired".
    • Clarified query-result field descriptions using ASCII quotation marks and standardized processing-unit names.
    • Updated blockingDDLs documentation to describe upstream tables reaching "synced" status.

@ti-chi-bot

ti-chi-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 7c5a4c5b-6a94-4629-a208-391716257689

📥 Commits

Reviewing files that changed from the base of the PR and between 80dffad and 039c92b.

📒 Files selected for processing (2)
  • dm/dm-continuous-data-validation.md
  • dm/dm-query-status.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The changes standardize English status terms, processing-unit labels, and quotation marks in two DM documentation pages. No functional or public entity changes are included.

Changes

DM documentation terminology

Layer / File(s) Summary
Status terminology normalization
dm/dm-continuous-data-validation.md, dm/dm-query-status.md
The documentation now uses "ignored", "resolved", "expired", "Check", "Dump", "Load", "Sync", and "synced" with ASCII quotation marks.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 039c9

This documentation update restores literal English status values, field names, and processing-unit labels in the Japanese DM pages. The documented changes match the intended terminology updates and present no remaining merge-readiness risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Japanese documentation scope and the restoration of quoted literal status and enum values.
Description check ✅ Passed The description explains the documentation changes, affected files and values, target version branch, related issue, and AI involvement. The selected i18n-ja-release-8.5 branch is more specific than t…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants