columnar: pin CSE FTS Spec v1 on cloud-engine - #11026
Conversation
Signed-off-by: 3pointer <l3pointer@foxmail.com>
Signed-off-by: 3pointer <l3pointer@foxmail.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: 3pointer <l3pointer@foxmail.com>
Signed-off-by: 3pointer <l3pointer@foxmail.com>
Signed-off-by: 3pointer <l3pointer@foxmail.com>
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
TiDB/CSE FTS Spec v1 uses
full_text_index.index_fieldsas the canonical ordered physical field layout. CSE now owns parsing, validation, and conversion of that metadata. This PR now pins the latestfts_spec_v1after itscloud-enginerebase (36128849380c), including match-expression query protocol support from tidbcloud/cloud-storage-engine#5801.The production TiFlash path builds CSE through
contrib/tiflash-columnar-hub, so TiFlash only needs to pin that CSE revision. TiFlash C++ does not need to parse or validate the FTS fields.What is changed and how it works?
contrib/cloud-storage-engineto36128849380c, the latestfts_spec_v1head after thecloud-enginerebase.pingcap/tantivy:cse-0.22.1and refreshCargo.lock. This parent-workspace patch is required because Cargo ignores a child workspace's[patch.crates-io]when CSE is built by columnar hub.column_idhandling, Analyzer parameters, andenable_bm25remain in CSE.Metadata compatibility:
index_fields; oldfilter_columnsand transitionalfieldsare not used as the physical layout.parser_typeremains readable in CSE for rolling upgrades of existing single-field indexes.Deployment order:
Check List
Tests
Completed locally on Apple arm64 (revalidated with CSE
36128849380c):cargo check --locked --manifest-path hub-runtime/Cargo.tomlmake debug, producing an arm64libtiflash_proxy.dylibcargo fmt --all -- --checkPending:
Side effects
Documentation
Release note