Skip to content

tici: preview port feature/fts onto master - #11041

Draft
3pointer wants to merge 1 commit into
pingcap:masterfrom
3pointer:codex/fts-port-preview
Draft

tici: preview port feature/fts onto master#11041
3pointer wants to merge 1 commit into
pingcap:masterfrom
3pointer:codex/fts-port-preview

Conversation

@3pointer

Copy link
Copy Markdown

What problem does this PR solve?

Issue Number: N/A

Problem Summary:

This draft PR provides a reviewable integration preview of the TiCI-backed FTS capability on the current TiFlash master branch. It applies the capability delta from 661e9b5887 to feature/fts HEAD instead of merging the feature branch history.

What is changed and how it works?

tici: preview port feature/fts onto master
  • Applies the feature capability patch on top of TiFlash master 5c72bfa56d.
  • Adds 18 new paths and integrates the cleanly applicable existing-file changes.
  • Resolves four textual conflicts in .gitmodules, MPPTask.cpp, gtest_new_kvstore.cpp, and tests/docker/util.sh.
  • Preserves master's bypass-lock lifecycle in MPPTask.cpp and adds TiCI QueryShardInfos initialization alongside it.
  • Keeps the newer master tipb pin.
  • Uses a client-c integration commit based on client-c master plus the TiCI remote-read delta: 3pointer/client-c@2214b0b.
  • Temporarily uses kvproto 811b5283cd, because the TiCI estimate-count RPC and its generated files cannot be cleanly separated from the intervening kvproto history. This dependency needs to be narrowed before a production merge.

The resulting top-level diff is 65 paths with 18 additions (+2833/-40). This PR is intended for diff review and effort assessment, not merge readiness.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual checks performed:

  • git diff --cached --check
  • bash -n tests/docker/util.sh tests/fullstack-test/run.sh tests/fullstack-test2/run.sh tests/tidb-ci/run.sh
  • Verified no unresolved conflict markers and exactly 18 added paths.
  • Started cargo check -p tici-search-lib; it reached the TiCI/searchlib dependency build without source errors, but was stopped while the first-time grpcio-sys C++ build was still running.

Full TiFlash configure/build was not run because the available CMake is 3.10.3 while the repository requires CMake 3.23 or newer.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 13, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign birdstorm for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e0afd4ad-37fe-489a-add6-0685ea6f038b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant