tici: preview port feature/fts onto master - #11041
Conversation
|
Skipping CI for Draft Pull Request. |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
This draft PR provides a reviewable integration preview of the TiCI-backed FTS capability on the current TiFlash master branch. It applies the capability delta from
661e9b5887tofeature/ftsHEAD instead of merging the feature branch history.What is changed and how it works?
5c72bfa56d..gitmodules,MPPTask.cpp,gtest_new_kvstore.cpp, andtests/docker/util.sh.MPPTask.cppand adds TiCIQueryShardInfosinitialization alongside it.tipbpin.811b5283cd, because the TiCI estimate-count RPC and its generated files cannot be cleanly separated from the intervening kvproto history. This dependency needs to be narrowed before a production merge.The resulting top-level diff is 65 paths with 18 additions (
+2833/-40). This PR is intended for diff review and effort assessment, not merge readiness.Check List
Tests
Manual checks performed:
git diff --cached --checkbash -n tests/docker/util.sh tests/fullstack-test/run.sh tests/fullstack-test2/run.sh tests/tidb-ci/run.shcargo check -p tici-search-lib; it reached the TiCI/searchlib dependency build without source errors, but was stopped while the first-timegrpcio-sysC++ build was still running.Full TiFlash configure/build was not run because the available CMake is 3.10.3 while the repository requires CMake 3.23 or newer.
Side effects
Documentation
Release note