Skip to content

fix(web): keep sidebar toggle icon consistent - #12606

Open
voltcrash wants to merge 1 commit into
pingdotgg:mainfrom
voltcrash:t3code/635f0ee3
Open

voltcrash wants to merge 1 commit into
pingdotgg:mainfrom
voltcrash:t3code/635f0ee3

Conversation

@voltcrash

@voltcrash voltcrash commented Sep 19, 2026

Copy link
Copy Markdown

Summary

The main sidebar toggle changed from a static panel icon to a close-state icon when the sidebar was open, so the same control did not match its hidden-sidebar appearance. This keeps PanelLeftIcon in both states, matching the existing static bottom and right panel openers.

Verification

  • vp lint apps/web/src/components/ui/sidebar.tsx
  • vp run --filter @t3tools/web typecheck
  • Integrated web pass verified the expanded and collapsed sidebar states and confirmed the bottom/right opener icons remain static.

Screenshots

Before:

before-ss

After:

after-ss

Implemented by opencode-go/gpt-5.6-luna via the OpenCode harness using T3 Code

Summary by CodeRabbit

  • Style
    • Updated the sidebar toggle button to consistently display the panel icon.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 19, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at a50d457

Macroscope's review found this PR approvable — This is a two-line, localized UI adjustment that keeps the sidebar toggle icon consistent without changing sidebar state, persistence, accessibility behavior, or other runtime workflows. It does not change product defaults or add static-analysis suppressions.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a0b1b439-7ef3-460d-8bd2-bbb85d20237f

📥 Commits

Reviewing files that changed from the base of the PR and between dfbb11b and a50d457.

📒 Files selected for processing (1)
  • apps/web/src/components/ui/sidebar.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The sidebar trigger now always renders PanelLeftIcon. The unused PanelLeftCloseIcon import was removed.

Changes

Sidebar trigger update

Layer / File(s) Summary
Unconditional trigger icon
apps/web/src/components/ui/sidebar.tsx
SidebarTrigger always renders PanelLeftIcon. The unused PanelLeftCloseIcon import was removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: maria-rcks

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: keeping the sidebar toggle icon consistent.
Description check ✅ Passed The description explains the change and rationale, includes verification steps, and provides before/after screenshots for the UI change. It does not use the template headings or include the checklist,…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant