Skip to content

fix(web): hovering an expanded command row no longer shifts its text - #12614

Open
atharvadeosthale wants to merge 1 commit into
pingdotgg:mainfrom
atharvadeosthale:fix/expanded-row-timestamp-shift
Open

atharvadeosthale wants to merge 1 commit into
pingdotgg:mainfrom
atharvadeosthale:fix/expanded-row-timestamp-shift

Conversation

@atharvadeosthale

@atharvadeosthale atharvadeosthale commented Sep 19, 2026

Copy link
Copy Markdown

What Changed

On an expanded work entry row, the hover timestamp now always reserves its width and stays invisible until the row is hovered or focused. Collapsed rows are unchanged: the timestamp still takes no space until hover.

One added className prop in MessagesTimeline.tsx.

Why

Since #8641, the timestamp switches from absolute to static on hover so it never overlaps the row text. On a collapsed row that only truncates the one-line preview a little earlier. On an expanded row the command text wraps, so taking width away on hover re-wraps the whole command, and the block jumps on every hover in and hover out.

Reserving the width up front on expanded rows means hover only changes opacity.

Checked in the dev web app against a copy of real thread data, on an expanded 510-character command row. Text width (575.39px), text height (136.5px), and row height (177.625px) are identical hovered and not hovered. Collapsed rows still compute position: absolute for the hidden timestamp.

UI Changes

Before:

before.mp4

After:

after.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Claude Fable 5.1 via Claude Code in T3 Code

Summary by CodeRabbit

  • Style
    • Updated the timestamp styling for expanded work entries in the chat timeline.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 19, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at f27a879

Macroscope's review found this PR approvable — This one-file UI fix reserves timestamp width only for expanded command rows, preventing hover-induced text reflow while leaving collapsed rows unchanged. The change is small, self-contained, and does not affect schemas, defaults, infrastructure, or sensitive code.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 587d1457-8e14-489c-be56-9f0288d61a0c

📥 Commits

Reviewing files that changed from the base of the PR and between b44c1ce and f27a879.

📒 Files selected for processing (1)
  • apps/web/src/components/chat/MessagesTimeline.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

PlainWorkEntryRow now gives TimelineRowTimestamp a static class when expanded. Collapsed rows retain the default behavior.

Changes

Work entry timestamp positioning

Layer / File(s) Summary
Conditional timestamp positioning
apps/web/src/components/chat/MessagesTimeline.tsx
The expanded work entry passes className="static" to TimelineRowTimestamp. Collapsed work entries pass no class name.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: maria-rcks

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main fix: preventing expanded command row text from shifting on hover.
Description check ✅ Passed The description includes What Changed, Why, UI Changes, testing details, screenshots, and checklist information. It clearly explains the focused change and its impact. The unchecked screenshot item co…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@atharvadeosthale

atharvadeosthale commented Sep 20, 2026

Copy link
Copy Markdown
Author

Hey @juliusmarminge, slight bump for this PR, this fixes a problem that irritates me everyday :D

Sorry for the ping, I will avoid pinging for this PR from now on.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant