Skip to content

fix(server): recover stale Codex approval callbacks #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luckyPipewrench wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

fix(server): recover stale Codex approval callbacks #5195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2566,15 +2566,15 @@ describe("ProviderCommandReactor", () => {
});
});

it("surfaces stale provider approval request failures without faking approval resolution", async () => {
it("normalizes stale Codex approval callbacks without faking approval resolution", async () => {
const harness = await createHarness();
const now = "2026-01-01T00:00:00.000Z";
harness.respondToRequest.mockImplementation(() =>
Effect.fail(
new ProviderAdapterRequestError({
provider: ProviderDriverKind.make("codex"),
method: "session/request_permission",
detail: "Unknown pending permission request: approval-request-1",
method: "item/requestApproval/decision",
detail: "Unknown pending Codex approval request: approval-request-1",
}),
),
);
Expand Down
8 changes: 5 additions & 3 deletions apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,15 @@ function isUnknownPendingApprovalRequestError(cause: Cause.Cause<ProviderService
const detail = error.detail.toLowerCase();
return (
detail.includes("unknown pending approval request") ||
detail.includes("unknown pending permission request")
detail.includes("unknown pending permission request") ||
detail.includes("unknown pending codex approval request")
);
}
const message = Cause.pretty(cause);
const message = Cause.pretty(cause).toLowerCase();
return (
message.includes("unknown pending approval request") ||
message.includes("unknown pending permission request")
message.includes("unknown pending permission request") ||
message.includes("unknown pending codex approval request")
);
}

Expand Down
Loading