Reduce boiler plate for Go container image C++ headers#2307
Open
ddelnano wants to merge 1 commit intopixie-io:mainfrom
Open
Reduce boiler plate for Go container image C++ headers#2307ddelnano wants to merge 1 commit intopixie-io:mainfrom
ddelnano wants to merge 1 commit intopixie-io:mainfrom
Conversation
Signed-off-by: Dom Del Nano <ddelnano@gmail.com> (cherry picked from commit 056e62f)
vihangm
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Reduce boiler plate for Go container image C++ headers
Previously, adding a new Go version required:
These header files account for ~100-200 lines of boilerplate code per Go version (~50 lines for each grpc and tls client/server pair) and add overhead when upgrading our Go version.
This PR reduces this boilerplate by generating these files with a new Bazel macro
go_container_libraries. This macro generates:go_1_24_grpc_server_container.h)go_grpc_server_containers.h,go_tls_client_containers.h)Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Build should succeed