Skip to content

Fix - Do not generate a consumable model per received consumable - #614

Open
RomainLvr wants to merge 1 commit into
mainfrom
fix/consumable-no-model-generation-on-delivery
Open

RomainLvr wants to merge 1 commit into
mainfrom
fix/consumable-no-model-generation-on-delivery

Conversation

@RomainLvr

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !46474
  • Here is a brief description of what this PR does

When automatic asset generation on delivery is enabled, receiving a consumable reference creates a new consumable model (A_COMPLETER…) for each received unit.

When the delivered lines are then linked to the real consumable model, a new consumable is created in that model. The generated models stay behind with no link to the order.

Fix

ConsumableItem is added to PluginOrderLink::getTypesThanCannotBeGenerated(), so consumables are handled the same way as cartridges:

  • no consumable model is generated on delivery
  • the delivered line stays unlinked until it is linked to an existing consumable model
  • a line that is already linked can no longer be linked again without unlinking it first

@RomainLvr
RomainLvr requested review from Lainow and MyvTsv September 23, 2026 15:41
@RomainLvr RomainLvr self-assigned this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants