Add properties OrganizationSharingLinkRecommendedExpirationInDays, OrganizationSharingLinkMaxExpirationInDays, OverrideTenantOrganizationSharingLinkExpirationPolicy to set-pnpsite, set-pnptenantsite#5333
Merged
Conversation
Collaborator
|
@reshmee011 - the code looks ok, but the docs are removing some parameter descriptions, can you check that ? It should only update docs for your changes. Example, AllowFileArchive, it should not be removed from docs. |
Collaborator
Author
|
@gautamdsheth , I realised after merging the PR #5330, that the properties I added to set-pnptenant.md already existed in the documentation, hence why removed those. I can exclude the set-pnptenant.md from this PR and create a new one to update set-pnptenant cmdlet. |
Collaborator
|
@reshmee011 - ahh ok, so it was duplicate or merge issue I guess ? All good then 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
What is in this Pull Request ?
Add properties OrganizationSharingLinkRecommendedExpirationInDays, OrganizationSharingLinkMaxExpirationInDays, OverrideTenantOrganizationSharingLinkExpirationPolicy to set-pnpsite, set-pnptenantsite