fix(launcher): dedupe release tweens - #408
Draft
lfkdsk wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher sends the same settle tweens twice on every key release.
onReleasecallssetSel(settle)and then unconditionally callsapplyTweens(settle). When the selection actually changed, thecreateEffectthat watches
sel()re-runs in the same frame and issues an identical tweenbatch, so the explicit call is redundant. The engine treats the duplicate as a
no-op (
spawn()kills the existing track and re-snapshotsfromfrom thecurrent resolved value, and nothing ticks between the two calls), so the extra
work is invisible on screen but real on the wire.
Recording the prior selection and only issuing the explicit tweens when the
selection did not change removes the duplicate while keeping both paths:
the tweens itself.
Deleting either path instead would regress: without the explicit call a long
hold that ends on the same card stops animating, and without the effect a touch
tap that only calls
setSelstops animating. Both were verified as permanentdivergences, not one-frame blips.
Measured
On the launcher's canonical 180-frame replay (measured at
1b452c1, before therebase onto current
main):animateFrame output is unchanged: the canonical replay plus long-hold, touch-tap and
idle tapes all match their pre-change per-frame framebuffer hashes.
Verification
bun tools/test.tsandbun tools/tape.ts replay hero-main --assertwere run onthis branch and on a pristine
mainworktree. Both show the same pre-existingfailures — five unit tests (
pocket-packagecorpus, fouripodtouch4-installationcases) and a frame-0 divergence of the committed
hero-maintape hashes — sothey are not introduced by this change.