Skip to content

perf: batch lazy builtin initialization #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eric-Song-Nop wants to merge 3 commits into
base: perf/release-cleanup-fast-path
Choose a base branch
from
Open

perf: batch lazy builtin initialization #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4ae546
perf: batch Date lazy builtin initialization
Eric-Song-Nop Sep 10, 2026
0274697
perf: batch Array and TypedArray builtin method tables
Eric-Song-Nop Sep 10, 2026
cdc35ec
docs(perf): report batch builtin gains and workload limitations
Eric-Song-Nop Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11,363 changes: 11,363 additions & 0 deletions docs/reports/batch-builtin-initialization.json
View file
Open in desktop

Large diffs are not rendered by default.

209 changes: 209 additions & 0 deletions docs/reports/batch-builtin-initialization.md
View file
Open in desktop

Large diffs are not rendered by default.

167 changes: 50 additions & 117 deletions src/engine/builtins/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use crate::engine::builtins::native::{
NativeFunctionId,
};
use crate::engine::heap::{AutoInitProperty, ContextId, HeapError, ObjectData, PropertySlot};
use crate::engine::object::builtin_properties::NativeBuiltinProperty;
use crate::engine::object::operations::{
ArrayLengthConversion, ArrayOwnKey, InternalDefineResult, PropertyDefineOutcome,
};
Expand Down Expand Up @@ -357,120 +358,85 @@ impl Runtime {
array_iterator_prototype: &ObjectRef,
global_object: &ObjectRef,
) -> Result<(), RuntimeError> {
self.define_native_builtin_auto_init(
array_prototype,
realm,
NativeFunctionId::ArrayPrototypeAt,
"at",
1,
1,
)?;
self.define_native_builtin_auto_init(
array_prototype,
realm,
NativeFunctionId::ArrayPrototypeWith,
"with",
2,
2,
)?;
self.define_native_builtin_auto_init(
array_prototype,
realm,
NativeFunctionId::ArrayPrototypeConcat,
"concat",
1,
0,
)?;
let mut methods = vec![
NativeBuiltinProperty::new(NativeFunctionId::ArrayPrototypeAt, "at", 1, 1),
NativeBuiltinProperty::new(NativeFunctionId::ArrayPrototypeWith, "with", 2, 2),
NativeBuiltinProperty::new(NativeFunctionId::ArrayPrototypeConcat, "concat", 1, 0),
];
for (kind, name) in [
(ArrayIterationKind::Every, "every"),
(ArrayIterationKind::Some, "some"),
(ArrayIterationKind::ForEach, "forEach"),
(ArrayIterationKind::Map, "map"),
(ArrayIterationKind::Filter, "filter"),
] {
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeIteration(kind),
name,
1,
1,
)?;
));
}
for (kind, name) in [
(ArrayReduceKind::Reduce, "reduce"),
(ArrayReduceKind::ReduceRight, "reduceRight"),
] {
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeReduce(kind),
name,
1,
1,
)?;
));
}
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeFill,
"fill",
1,
1,
)?;
));
for (kind, name) in [
(ArrayFindKind::Find, "find"),
(ArrayFindKind::FindIndex, "findIndex"),
(ArrayFindKind::FindLast, "findLast"),
(ArrayFindKind::FindLastIndex, "findLastIndex"),
] {
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeFind(kind),
name,
1,
1,
)?;
));
}
for (kind, name) in [
(ArraySearchKind::IndexOf, "indexOf"),
(ArraySearchKind::LastIndexOf, "lastIndexOf"),
(ArraySearchKind::Includes, "includes"),
] {
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeSearch(kind),
name,
1,
1,
)?;
));
}
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeJoin(ArrayJoinKind::Join),
"join",
1,
1,
)?;
self.define_native_builtin_auto_init(
array_prototype,
realm,
));
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeToString,
"toString",
0,
0,
)?;
self.define_native_builtin_auto_init(
array_prototype,
realm,
));
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeJoin(ArrayJoinKind::ToLocaleString),
"toLocaleString",
0,
0,
)?;
));
for (target, name, length) in [
(
NativeFunctionId::ArrayPrototypePop(ArrayPopKind::Pop),
Expand All @@ -493,97 +459,81 @@ impl Runtime {
1,
),
] {
self.define_native_builtin_auto_init(array_prototype, realm, target, name, length, 0)?;
methods.push(NativeBuiltinProperty::new(target, name, length, 0));
}
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeReverse,
"reverse",
0,
0,
)?;
self.define_native_builtin_auto_init(
array_prototype,
realm,
));
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeToReversed,
"toReversed",
0,
0,
)?;
self.define_native_builtin_auto_init(
array_prototype,
realm,
));
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeSort,
"sort",
1,
1,
)?;
self.define_native_builtin_auto_init(
array_prototype,
realm,
));
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeToSorted,
"toSorted",
1,
1,
)?;
));
for (kind, name) in [
(ArraySliceKind::Slice, "slice"),
(ArraySliceKind::Splice, "splice"),
] {
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeSlice(kind),
name,
2,
2,
)?;
));
}
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeToSpliced,
"toSpliced",
2,
2,
)?;
self.define_native_builtin_auto_init(
array_prototype,
realm,
));
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeCopyWithin,
"copyWithin",
2,
2,
)?;
));
for (kind, name, length, min_readable_args) in [
(ArrayFlattenKind::FlatMap, "flatMap", 1, 1),
(ArrayFlattenKind::Flat, "flat", 0, 0),
] {
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeFlatten(kind),
name,
length,
min_readable_args,
)?;
));
}
for (kind, name) in [
(ArrayIteratorKind::Value, "values"),
(ArrayIteratorKind::Key, "keys"),
(ArrayIteratorKind::KeyAndValue, "entries"),
] {
self.define_native_builtin_auto_init(
array_prototype,
realm,
methods.push(NativeBuiltinProperty::new(
NativeFunctionId::ArrayPrototypeIterator(kind),
name,
0,
0,
)?;
));
}

self.define_native_builtin_auto_init_batch(array_prototype, realm, methods)?;

self.define_native_builtin_auto_init(
array_iterator_prototype,
realm,
Expand Down Expand Up @@ -619,30 +569,13 @@ impl Runtime {
"Array",
1,
)?;
self.define_native_builtin_auto_init(
constructor.as_object(),
realm,
NativeFunctionId::ArrayIsArray,
"isArray",
1,
1,
)?;
self.define_native_builtin_auto_init(
constructor.as_object(),
realm,
NativeFunctionId::ArrayFrom,
"from",
1,
3,
)?;
self.define_native_builtin_auto_init(
constructor.as_object(),
realm,
NativeFunctionId::ArrayOf,
"of",
0,
0,
)?;
let methods = [
NativeBuiltinProperty::new(NativeFunctionId::ArrayIsArray, "isArray", 1, 1),
NativeBuiltinProperty::new(NativeFunctionId::ArrayFrom, "from", 1, 3),
NativeBuiltinProperty::new(NativeFunctionId::ArrayOf, "of", 0, 0),
];
self.define_native_builtin_auto_init_batch(constructor.as_object(), realm, methods)?;

self.define_constructor_relationship(&constructor, array_prototype)?;

let getter = self.new_native_builtin(
Expand Down
Loading
Loading