repo: incidental-complexity sweep (−1.9k LOC) - #260
Merged
Conversation
…ges, deletion archaeology
Adversarial review across all territories; every deletion verified
against repo-wide usage (incl. consumers, generated code, CI).
Dead code: deferredCapability, setMaxFlatResultsForTesting,
containsAsyncValue/NO_EVENT/isBulkListKind, no-op try/catch in
translateCached, gen-overlay.ts, repro_stream_pump.ts, unified
duplicate debug-id minting onto dbgId.
Speculative hedges: sockets platform seam optional-capability guards
(one backend, implements everything), cli({passthrough}),
http({version}) rc re-keying, sync() accessor branch, unreachable
digest structural-diff machinery (contracts/digest.md amended:
'fails fast on mismatch').
Surface trims (breaking labels): runtime embedder @internal
version/casing exports; ct-runner @internal re-exports plus ./imports
and ./run subpaths; protocol RUNTIME_COPIES. Lockstep 0.5.2 -> 0.6.0
(+ RUNTIME_VERSION), protocol 0.2.4 -> 0.3.0. Conventions goldens
untouched.
Consolidation: protocol mark-decorator triplication -> makeMark;
bindgen CLI bare-vs-subcommand dedupe; wit-bindgen-core dropped for a
local Source buffer (snapshot-verified byte-identical), wit-parser
=0.252.0 pairing with translator-shim.
Fixtures/config/docs: yield-only + backpressure-probe guests deleted
(built every CI run, consumed by nothing); harness/deno.json browser:*
tasks and exports map; AGENTS.md gates listing collapsed onto the
justfile (it had drifted); stale sync-streams upstream filing kit
dropped. Deletion-event archaeology (CM#705/#173 and older series)
rewritten as forward rationale or removed throughout runtime and
xfail.ts.
lannbot
enabled auto-merge
September 2, 2026 02:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial review for incidental complexity across the whole tree, then execution of every finding. Five parallel reviewers over disjoint territories; every deletion verified against repo-wide usage (consumers, generated code, CI) before removal. Net: +614 / −2386.
Dead code (verified zero callers)
deferredCapability,setMaxFlatResultsForTesting(+MAX_FLAT_RESULTSnowconst),containsAsyncValue,NO_EVENT,isBulkListKind— orphans of the PR embedder: structured-clone-safe boundary forms (A20, #131) #219 windowtranslateCached(both branches rethrew unmodified)tools/browser/gen-overlay.ts(no invoker; classifier frozen at closed M3A-1)tools/smoke-c0/repro_stream_pump.ts+reprotask (fixed bug, superseded byhost_pump_test.ts)dbgId(trace ids now correlate across probes)Speculative hedges
would-blockinstead ofnot-supported) if ever reachable. Option-honestynot-supportedpaths preserved.cli({ passthrough })— set by nobody, buggy (newline-injecting)http({ version })rc re-keying — only caller was its own test with a fabricated version; the manual re-key escape remains documentedsync()accessor-property branch — hedged an input the producer never producesfirstDivergencealways null); contracts/digest.md amended to the behavior that ships: fails fast on mismatch. Codegen comment fixed + six generated headers regenerated (comment-only delta).Surface trims (the breaking labels)
@internalversion/casing parser exports off./embedder(parseLeafName,parseSemver,trackKey, …);DigestMismatch.firstDivergencefield removedCliOptions.passthrough,HttpOptions.versionremoved@internalre-exports (Context/tags/TESTS_INTERFACE…) and the./imports+./runsubpaths removed;ImportAnalysiskept (return type of publicanalyzeImports)RUNTIME_COPIESun-exported (own doc: @internal; the contract's example usesSymbol.for)Versions: lockstep 0.5.2 → 0.6.0 (+
RUNTIME_VERSION), protocol 0.2.4 → 0.3.0. Conventions goldens byte-identical.Consolidation
makeMark(exports, messages, behavior byte-identical; tests unchanged)generate-subcommand duplication deleted (bare form kept — the one generated headers document)wit-bindgen-coredependency dropped: its only use wasSourceas a string buffer; replaced with a snapshot-verified byte-identical local buffer, freeingwit-parserto pin =0.252.0 alongside translator-shim's wasmparser and deleting the 28-line pin-pairing essayFixtures / config / docs
yield-only+backpressure-probeguests deleted (built every CI run, consumed by no test)browser:*tasks + dead exports map removed (lanes run viajust browser-lane)Gates
Full
just gatesgreen over the final tree (core suites through conformance/sched-seeds/shells in one run; browsers/smoke-tls/smoke-c0 after a one-timejust browsers-installin this worktree).test-npmcaught one reviewer miss — the consumer smoke probed the removedct-runner/runsubpath — fixed by dropping the stale probe entry.