Adopt just as the command surface: recipes are the exact commands, CI runs them - #35
Merged
Conversation
… runs them The root justfile carries the repo-wide recipes (builders, suites, engine lanes, consumer smokes, release artifacts); .github/justfile is the `gha` module holding the CI job bodies - each workflow job runs exactly one gha:: recipe, so `just ci` is exactly CI (the polymorph-websocket pattern). Workflow step comments move onto the recipes they now describe. - ci.yml core/browser, canary.yml, and release.yml collapse to setup plus one `just` step each (-194 lines of workflow logic); job names and the required-check surface are unchanged. - Step-level continue-on-error becomes the gha::_step-tolerated wrapper (webrtc #21, webkit #11); the jsc-pinned x64-only conditional becomes an arch guard in `shells`. - `just gates` is the full AGENTS.md pre-commit pass as one command; AGENTS.md Gates and the README quick start point at the recipes. - cargo test gains -p testgen (AGENTS.md listed it; CI didn't; trivially green either way).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root justfile carries the repo-wide recipes;
.github/justfileis theghamodule with the CI job bodies — each workflow job runs exactly onegha::recipe, sojust ciis exactly CI (the polymorph-websocket pattern, currently rolling out across the family). Step-level rationale that lived on workflow steps lives on the recipes now; the workflows keep only environment setup (−194 lines of workflow logic; job names and the required-check surface unchanged).Semantics preserved, mechanically moved:
continue-on-errorsteps (webrtc ports/webrtc loopback tests: no ICE connectivity on GH Actions runners #21, webkit Re-check shipping Safari JSPI; track JSC multi-memory (WebKit lane cap) #11) →gha::_step-tolerated(::warning annotation, never a job failure)if: runner.arch == 'X64'on jsc-pinned → arch guard injust shellsjust sched-seeds(DELTIC_SCHED_SEED=1, =4242, harness seed 1)just release-artifacts(byte-identical cargo flags; also locally runnable now)cargo testgains-p testgen(AGENTS.md listed it, CI didn't; trivially green)New conveniences:
just gates= the full AGENTS.md pre-commit pass (including the consumer smokes CI can't run);just check= fast sanity;just --listdocumented throughout.Validated locally (linux-arm64, warm): every recipe run individually — core suites, seeds, sm-pinned shell lane, chromium+firefox browser lanes, ports incl. webrtc 9/9, smoke-tls PASS, smoke-c0 legs PASS, websocket-conformance 55/55, release-artifacts (checksums reproduced) — plus
just gha::coreend-to-end (22.5 s warm). Not validated locally:iroh-exam(no iroh-relay on this box) and the jsc lanes (x64-only — the PR's x64 core leg exercises jsc-pinned). Canary recipes validated via workflow_dispatch on this branch (run linked below).