Repository navigation
Fix deploy workflow silently dropping build artifacts - #2
Merged
Merged
Conversation
peaceiris/actions-gh-pages was publishing straight from the repo checkout (publish_dir: .), so the checkout's own .gitignore -- which now lists litewrite.min.js/service-worker.js/workbox-*.js as build artifacts -- got copied along and caused those exact files to be silently excluded from the published gh-pages branch. Stage a clean site/ directory with only the runtime files instead, so gitignore has no bearing on what gets published. Also drop the now gone gh-pages branch from CI's push triggers (the source branch was renamed to main). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016dMGgm5wjaHdA4CBZLRi8Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Deployworkflow added in #1 published straight from the repo checkout (publish_dir: .). Since that checkout's own.gitignorenow listslitewrite.min.js,service-worker.js, andworkbox-*.jsas build artifacts,peaceiris/actions-gh-pagesrespected it when copyingpublish_dirand silently dropped exactly the files the live site needs. This was confirmed after a deploy run: the resultinggh-pagesbranch had everything except those three files.site/directory containing only the runtime files (index.html, the built JS/service worker,CNAME,img/,style/) and publish that instead, so.gitignorehas no bearing on what gets copiedgh-pagesfrom CI's push triggers now that the source branch has been renamed tomainTest plan
npm run build+ manually assembled thesite/staging directory locally — confirmedlitewrite.min.js,litewrite.min.js.LICENSE.txt,service-worker.js, andworkbox-*.jsare all present this timenpm run lintpasses cleanGenerated by Claude Code