Merged
Conversation
stevensJourney
approved these changes
Jan 9, 2026
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
This is a clever solution to a horrible problem. I hope XCode supports package traits soon - I'm happy with this as a work around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
Encryptionpackage trait to ourCSQLitefork. When enabled, we'll compile SQLite3MultipleCiphers instead of SQLite.This is a horrible hack to work around XCode not supporting package traits. We can't enable package traits in our Swift SDK for that reason, but we can ask users interested in encryption to add a direct dependency on CSQLite from their project and enable the
Encryptiontrait. Because a Swift build only compiles a given package once, this essentially hacks our Swift SDK to also depend on theEncryptiontrait, causing sqlite3mc to get linked.This also means that we'll just have a single target now. To conditionally include SQLite vs. SQLite3MultipleCiphers, I've added entry headers and C files that include either library depending on whether the package trait is enabled. Given how unreliable all of this sounds, we'll only really know if this works when it's released. But I managed to get encryption working with this approach and local dependencies.