Skip to content

RTBHouse: Extract tagid from Imp fields #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piotrj-rtbh wants to merge 3 commits into
base: master
Choose a base branch
from
+198 −1
Open

RTBHouse: Extract tagid from Imp fields #4306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52c550f
RTBHouse: Extract tagid from Imp fields
piotrj-rtbh Dec 2, 2025
bc4cb7a
RTBHouse: Preserve existing tagid in Imp when modifying requests
piotrj-rtbh Dec 2, 2025
d30af84
RTBHouse: refactor tag ID extraction logic
piotrj-rtbh Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions src/main/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidder.java
View file
Open in desktop
Copy link
Collaborator

@CTMBNara CTMBNara Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrange methods in call order

Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,59 @@ private ExtImpRtbhouse parseImpExt(Imp imp) {

private static Imp modifyImp(Imp imp, Price bidFloorPrice) {
return imp.toBuilder()
.tagid(extractTagId(imp))
.bidfloorcur(ObjectUtil.getIfNotNull(bidFloorPrice, Price::getCurrency))
.bidfloor(ObjectUtil.getIfNotNull(bidFloorPrice, Price::getValue))
.pmp(null)
.build();
}

private static String extractTagId(Imp imp) {
final String existingTagid = imp.getTagid();
if (StringUtils.isNotBlank(existingTagid)) {
return existingTagid;
}

return extractTagIdFromExt(imp);
}

private static String extractTagIdFromExt(Imp imp) {
return Optional.ofNullable(imp.getExt())
.flatMap(ext -> extractGpid(ext))
.orElseGet(() -> extractFromData(imp));
}

private static Optional<String> extractGpid(JsonNode ext) {
return Optional.ofNullable(ext.get("gpid"))
.filter(JsonNode::isTextual)
.map(JsonNode::asText)
.filter(StringUtils::isNotBlank);
}

private static String extractFromData(Imp imp) {
return Optional.ofNullable(imp.getExt())
.map(ext -> ext.get("data"))
.filter(JsonNode::isObject)
.flatMap(data -> extractAdslot(data).or(() -> extractPbadslot(data)))
.orElseGet(() -> Optional.ofNullable(imp.getId()).filter(StringUtils::isNotBlank).orElse(null));
}

private static Optional<String> extractAdslot(JsonNode data) {
return Optional.ofNullable(data.get("adserver"))
.filter(JsonNode::isObject)
.map(adserver -> adserver.get("adslot"))
.filter(JsonNode::isTextual)
.map(JsonNode::asText)
.filter(StringUtils::isNotBlank);
}

private static Optional<String> extractPbadslot(JsonNode data) {
return Optional.ofNullable(data.get("pbadslot"))
.filter(JsonNode::isTextual)
.map(JsonNode::asText)
.filter(StringUtils::isNotBlank);
}

private Price resolveBidFloor(Imp imp, ExtImpRtbhouse impExt, BidRequest bidRequest) {
final List<String> brCur = bidRequest.getCur();
final Price initialBidFloorPrice = Price.of(imp.getBidfloorcur(), imp.getBidfloor());
Expand Down
149 changes: 149 additions & 0 deletions src/test/java/org/prebid/server/bidder/rtbhouse/RtbhouseBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,147 @@ public void makeHttpRequestsShouldAlwaysRemovePmpField() {
.containsOnlyNulls();
}

@Test
public void makeHttpRequestsShouldSetTagidFromGpid() {
// given
final BidRequest bidRequest = BidRequest.builder()
.imp(singletonList(Imp.builder()
.id("imp123")
.ext(givenRtbhouseExt(node -> node.put("gpid", "gpid_value")))
.build()))
.id("request_id")
.build();

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getTagid)
.containsExactly("gpid_value");
}

@Test
public void makeHttpRequestsShouldSetTagidFromAdserverAdslot() {
// given
final BidRequest bidRequest = BidRequest.builder()
.imp(singletonList(Imp.builder()
.id("imp123")
.ext(givenRtbhouseExt(node -> node.set("data", mapper.createObjectNode()
.set("adserver", mapper.createObjectNode().put("adslot", "adslot_value")))))
.build()))
.id("request_id")
.build();

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getTagid)
.containsExactly("adslot_value");
}

@Test
public void makeHttpRequestsShouldSetTagidFromPbadslot() {
// given
final BidRequest bidRequest = BidRequest.builder()
.imp(singletonList(Imp.builder()
.id("imp123")
.ext(givenRtbhouseExt(node -> node.set("data", mapper.createObjectNode()
.put("pbadslot", "pbadslot_value"))))
.build()))
.id("request_id")
.build();

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getTagid)
.containsExactly("pbadslot_value");
}

@Test
public void makeHttpRequestsShouldSetTagidFromImpIdWhenNoOtherFields() {
// given
final BidRequest bidRequest = givenBidRequest(
bidReq -> bidReq.id("request_id"),
imp -> imp.id("imp123"),
identity());

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getTagid)
.containsExactly("imp123");
}

@Test
public void makeHttpRequestsShouldSetTagidToNullWhenNoFieldsAvailable() {
// given
final BidRequest bidRequest = BidRequest.builder()
.imp(singletonList(Imp.builder()
.id(null)
.ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpRtbhouse.builder()
.publisherId("publisherId")
.region("region")
.build())))
.build()))
.id("request_id")
.build();

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getTagid)
.containsOnlyNulls();
}

@Test
public void makeHttpRequestsShouldPreserveExistingTagid() {
// given
final BidRequest bidRequest = BidRequest.builder()
.imp(singletonList(Imp.builder()
.id("imp123")
.tagid("existing_tagid")
.ext(givenRtbhouseExt(node -> node.put("gpid", "gpid_value")))
.build()))
.id("request_id")
.build();

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getTagid)
.containsExactly("existing_tagid");
}

private static BidResponse givenBidResponse(Function<Bid.BidBuilder, Bid.BidBuilder> bidCustomizer) {
return BidResponse.builder()
.cur("USD")
Expand Down Expand Up @@ -562,4 +703,12 @@ private static Imp givenImp(Function<Imp.ImpBuilder, Imp.ImpBuilder> impCustomiz
.build()))))
.build();
}

private static ObjectNode givenRtbhouseExt(Function<ObjectNode, ObjectNode> extCustomizer) {
final ObjectNode extNode = (ObjectNode) mapper.valueToTree(ExtPrebid.of(null, ExtImpRtbhouse.builder()
.publisherId("publisherId")
.region("region")
.build()));
return extCustomizer.apply(extNode);
}
}
3 changes: 2 additions & 1 deletion src/test/resources/org/prebid/server/it/openrtb2/rtbhouse/test-rtbhouse-bid-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"bidder": {
"publisherId": "publisherId"
}
}
},
"tagid": "imp_id"
}
],
"source": {
Expand Down
Loading