perf(validators): cache compiled AJV schemas instead of recompiling per call#94
Open
forgou37 wants to merge 1 commit into
Open
perf(validators): cache compiled AJV schemas instead of recompiling per call#94forgou37 wants to merge 1 commit into
forgou37 wants to merge 1 commit into
Conversation
…g each call validate() was creating a new AJV instance and recompiling the schema on every invocation. Schema compilation is expensive (JSON Schema parsing, format setup). Cache the compiled validator per SchemaKind so compilation happens once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AJV
compile()is expensive. The validators module was calling it on every validation request. This PR caches the compiled validator functions at module load time, avoiding repeated recompilation and improving throughput for high-frequency validation paths.