feat(chart): add certificate properties#1054
Merged
oliverbaehler merged 3 commits intoJun 17, 2026
Merged
Conversation
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
There was a problem hiding this comment.
Pull request overview
This PR extends the Helm chart’s cert-manager configuration to expose additional certificate lifecycle properties (e.g., duration / renewBefore) for both the CA and serving certificates, and wires them through chart documentation and schema validation.
Changes:
- Added
certManager.caand newduration/renewBeforevalues forcertManager.certificate. - Updated
certmanager.yamltemplate to render these new cert-managerCertificate.specfields. - Updated
values.schema.jsonand chartREADME.mdto document and validate the new options.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| charts/capsule-proxy/values.yaml | Adds new cert-manager values for CA and serving certificate lifecycle configuration. |
| charts/capsule-proxy/values.schema.json | Adds schema entries for the new cert-manager values. |
| charts/capsule-proxy/templates/certmanager.yaml | Renders new CA/serving duration and renewBefore fields; adds CA field injection. |
| charts/capsule-proxy/README.md | Documents the newly added chart values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+43
| {{- with .Values.certManager.ca.privateKey }} | ||
| privateKey: | ||
| algorithm: ECDSA | ||
| size: 256 | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
Comment on lines
336
to
+340
| certificate: | ||
| # -- Duration of validity for the CA certificate (e.g. 2160h for 90 days) | ||
| duration: "" | ||
| # -- Renew the CA certificate before its expiration time (e.g. 360h for 15 days) | ||
| renewBefore: "" |
Comment on lines
+90
to
+93
| "duration": { | ||
| "description": "Duration of validity for the CA certificate (e.g. 2160h for 90 days)", | ||
| "type": "string" | ||
| }, |
Comment on lines
+116
to
+119
| "renewBefore": { | ||
| "description": "Renew the CA certificate before its expiration time (e.g. 360h for 15 days)", | ||
| "type": "string" | ||
| }, |
Comment on lines
+213
to
+217
| | certManager.certificate.duration | string | `""` | Duration of validity for the CA certificate (e.g. 2160h for 90 days) | | ||
| | certManager.certificate.fields | object | `{"privateKey":{"rotationPolicy":"Always"}}` | Additional fields to include in certificate | | ||
| | certManager.certificate.includeInternalServiceNames | bool | `true` | Include internal service names in certificate (disable if you create a public cert) | | ||
| | certManager.certificate.ipAddresses | list | `[]` | Additional IP Addresses to include in certificate | | ||
| | certManager.certificate.renewBefore | string | `""` | Renew the CA certificate before its expiration time (e.g. 360h for 15 days) | |
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.