fix: exclude standalone examples from mise run format#1931
Merged
zeitlinger merged 3 commits intomainfrom Mar 4, 2026
Merged
Conversation
Standalone example POMs don't inherit the spotless plugin from the project parent, so `spotless:apply` fails when they're in the reactor (JDK 25+ activates the examples-and-integration-tests profile). Use the fully-qualified plugin goal with profile deactivation to skip these modules. Add a `lint:example-poms` check to catch this class of issue in the future. Fixes #1927 Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
- chmod +x example-poms.py so mise discovers it as a task - Remove stale `./mvnw spotless:apply` comment from AGENTS.md - Add "run lint before pushing" rule to AGENTS.md Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
approved these changes
Mar 3, 2026
Collaborator
jaydeluca
left a comment
jaydeluca
left a comment
There was a problem hiding this comment.
thanks for jumping on this!
| **ALWAYS** run `mise run lint` before pushing to verify | ||
| all lints pass. CI runs the same checks and will fail | ||
| if any lint is violated. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mise run format(i.e.spotless:apply) fails on JDK 25+ becausestandalone example POMs don't inherit the spotless plugin from the
project parent, but are pulled into the reactor via the
examples-and-integration-testsprofilelint:example-pomscheck to catch this class of issueRelates #1927 (comment)
Test plan
mise run formatsucceedslint:example-pomspasses with the fixlint:example-pomsfails when reverting the fix