Fix server shutdown documentation #1155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the HTTP server shutdown documentation to include the
server.server_close()call, which is required to properly release the port and allow the server to be restarted on the same port.Problem
Without calling
server.server_close(), attempting to restart the server on the same port results in anOSError: [Errno 98] Address already in useerror.Changes
server.server_close()call to the server shutdown example in the HTTP documentationTest Plan
Manual Testing:
Created and ran a test script that:
shutdown()andserver_close()Before fix:
After fix:
The test passes successfully with the updated documentation.
Fixes #1068