[BOX32][WRAPPER] Fix inverted condition in del_cond()#3517
Merged
ptitSeb merged 1 commit intoptitSeb:mainfrom Feb 16, 2026
Merged
[BOX32][WRAPPER] Fix inverted condition in del_cond()#3517ptitSeb merged 1 commit intoptitSeb:mainfrom
ptitSeb merged 1 commit intoptitSeb:mainfrom
Conversation
del_cond() had an inverted kh_end check introduced in bebae71. k==kh_end(mapcond) means key NOT found, but the code proceeded to call box_free and kh_del on the invalid iterator. Fix: change == to != to match the correct khash idiom used elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
del_cond() had an inverted kh_end check introduced in bebae71.
k==kh_end(mapcond) means key "not found".
so it was never freed from the map, leaking memory on every call.
This causes use-after-free when cond is not in map and fails to delete
when it is in the map.
Fix: change == to != to match the correct khash idiom used elsewhere.